fix: dom not appended should not be treated as ShadowRoot (#457)

react-component · Aug 4, 2023 · cc74b27 · cc74b27 · vercel · Aug 4, 2023
1 parent 2ced0b2
commit cc74b27
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/Dom/shadow.ts b/src/Dom/shadow.ts
@@ -6,7 +6,7 @@ function getRoot(ele: Node) {
  * Check if is in shadowRoot
  */
 export function inShadow(ele: Node) {
-  return getRoot(ele) !== ele?.ownerDocument;
+  return getRoot(ele) instanceof ShadowRoot;
 }
 
 /**

diff --git a/tests/shadow.test.tsx b/tests/shadow.test.tsx
@@ -19,5 +19,10 @@ describe('shadow', () => {
 
       expect(getShadowRoot(button)).toBeNull();
     });
+
+    it('should return null if dom is not appended', () => {
+      const button = document.createElement('button');
+      expect(getShadowRoot(button)).toBeNull();
+    });
   });
 });