Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dom not appended should not be treated as ShadowRoot #457

Merged
merged 1 commit into from
Aug 4, 2023
Merged

fix: dom not appended should not be treated as ShadowRoot #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Dom/shadow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ function getRoot(ele: Node) {
* Check if is in shadowRoot
*/
export function inShadow(ele: Node) {
return getRoot(ele) !== ele?.ownerDocument;
return getRoot(ele) instanceof ShadowRoot;
}

/**
Expand Down
5 changes: 5 additions & 0 deletions tests/shadow.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,10 @@ describe('shadow', () => {

expect(getShadowRoot(button)).toBeNull();
});

it('should return null if dom is not appended', () => {
const button = document.createElement('button');
expect(getShadowRoot(button)).toBeNull();
});
});
});
Loading