Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useComposeRef memo logic #458

Merged
merged 1 commit into from
Aug 8, 2023
Merged

fix: useComposeRef memo logic #458

merged 1 commit into from
Aug 8, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 8, 2023

useComposeRef 的 memo 逻辑写反了,导致用了它总是会重新刷新 ref。

@vercel
Copy link

vercel bot commented Aug 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
util ✅ Ready (Inspect) Visit Preview Aug 8, 2023 2:26am

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #458 (e8bea14) into master (2ced0b2) will increase coverage by 0.11%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head e8bea14 differs from pull request most recent head 195130c. Consider uploading reports for the commit 195130c to get more accurate results

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
+ Coverage   91.49%   91.60%   +0.11%     
==========================================
  Files          38       38              
  Lines         905      905              
  Branches      274      289      +15     
==========================================
+ Hits          828      829       +1     
+ Misses         75       74       -1     
  Partials        2        2              
Files Changed Coverage Δ
src/Dom/shadow.ts 100.00% <100.00%> (ø)
src/ref.ts 100.00% <100.00%> (+3.70%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zombieJ zombieJ merged commit 25fd32b into master Aug 8, 2023
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-ref branch August 8, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant