chore: bump node to 20 #2151
chore: bump node to 20 #2151
Conversation
szymonrybczak
force-pushed
the
chore/bump-to-node-20
branch
from
d7dbd2a
to
bd9e252
Compare
|
rebase needed |
szymonrybczak
force-pushed
the
chore/bump-to-node-20
branch
from
bd9e252
to
4ea7689
Compare
szymonrybczak
force-pushed
the
chore/bump-to-node-20
branch
from
4ea7689
to
0ca62cc
Compare
|
CI Green, good to merge! |
| @@ -10,7 +10,7 @@ module.exports = { | |||
| [ | |||
| require.resolve('@babel/preset-env'), | |||
| { | |||
| targets: {node: '18'}, | |||
| targets: {node: '20'}, | |||
There was a problem hiding this comment.
Will RN 0.74 drop node 18? 0.73 targets node 18 as minimum so we need to keep this as 18, otherwise it’s a breaking change
There was a problem hiding this comment.
No, please look at the PR description.
There was a problem hiding this comment.
If the build step targets Node 20, running on Node 18 would be unsafe (even though it might work), so this looks like a breaking change to me?
There was a problem hiding this comment.
Ah, make sense 👍
There was a problem hiding this comment.
Ah, looks like babel.config.js only used for local development, and tsc (targeting ES2017) is used for npm builds? If that's the case this particular change isn't user facing.
But the bump of @types/node would allow the use of runtime features that aren't supported by Node 18. What's the motivation?
There was a problem hiding this comment.
The initial purpose of this PR was to address a CI failures on Node v20, but we've resolved it by upgrading some dependencies so we don't need to bump Node now.
Summary:
Bumps node version to 20, to unblock #2015.
It doesn't mean that to run CLI user needs Node 20:
Minimal Node version is stored here:
cli/packages/cli-doctor/src/tools/versionRanges.ts
Line 3 in 3f206fd
Test Plan:
CI
Checklist