-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications: remove unused notification #11573
Open
stsewd
wants to merge
5
commits into
main
Choose a base branch
from
improve-deploy-key-failure-message
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
force-pushed
the
improve-deploy-key-failure-message
branch
from
September 3, 2024 17:53
8c19795
to
9554248
Compare
humitos
reviewed
Sep 4, 2024
agjohnson
reviewed
Sep 10, 2024
I'll re-purpose this PR to delete the unused notification instead (https://github.com/readthedocs/readthedocs-corporate/pull/1866#discussion_r1821118646), since we no longer use the notification that was added here. |
stsewd
changed the title
Add Notification for failure to add deploy key on manual imported project
Notifications: remove unused notification
Oct 29, 2024
agjohnson
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://github.com/readthedocs/readthedocs-corporate/issues/1806