Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: remove unused notification #11573

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Aug 29, 2024

@stsewd stsewd force-pushed the improve-deploy-key-failure-message branch from 8c19795 to 9554248 Compare September 3, 2024 17:53
@stsewd stsewd marked this pull request as ready for review September 3, 2024 23:52
@stsewd stsewd requested a review from a team as a code owner September 3, 2024 23:52
readthedocs/oauth/notifications.py Outdated Show resolved Hide resolved
readthedocs/oauth/notifications.py Outdated Show resolved Hide resolved
@ericholscher ericholscher removed their request for review October 2, 2024 13:36
@stsewd
Copy link
Member Author

stsewd commented Oct 29, 2024

I'll re-purpose this PR to delete the unused notification instead (https://github.com/readthedocs/readthedocs-corporate/pull/1866#discussion_r1821118646), since we no longer use the notification that was added here.

@stsewd stsewd changed the title Add Notification for failure to add deploy key on manual imported project Notifications: remove unused notification Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants