Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a null pointer exception in Route53ResolverRule #1134

Closed
wants to merge 1 commit into from

Conversation

sinisa229
Copy link

When we are running nuke, we get the following error:

goroutine 1 [running]:
--
690 | github.com/rebuy-de/aws-nuke/v2/resources.(*Route53ResolverRule).Filter(0xc002339430?)
691 | /src/resources/route53-resolver-rules.go:103 +0x12
692 | github.com/rebuy-de/aws-nuke/v2/cmd.(*Nuke).Filter(0xc0003c8840, 0xc0013afcc0)
693 | /src/cmd/nuke.go:196 +0x53
694 | github.com/rebuy-de/aws-nuke/v2/cmd.(*Nuke).Scan(0xc0003c8840)
695 | /src/cmd/nuke.go:173 +0x9cb
696 | github.com/rebuy-de/aws-nuke/v2/cmd.(*Nuke).Run(0xc0003c8840)
697 | /src/cmd/nuke.go:61 +0x325
698 | github.com/rebuy-de/aws-nuke/v2/cmd.NewRootCommand.func2(0xc00034e800?, {0x5843b0d?, 0x4?, 0x5843b11?})
699 | /src/cmd/root.go:92 +0x613
700 | github.com/spf13/cobra.(*Command).execute(0xc0002c8300, {0xc0000b4010, 0xb, 0xb})
701 | /src/vendor/github.com/spf13/cobra/command.go:940 +0x87c
702 | github.com/spf13/cobra.(*Command).ExecuteC(0xc0002c8300)
703 | /src/vendor/github.com/spf13/cobra/command.go:1068 +0x3a5
704 | github.com/spf13/cobra.(*Command).Execute(0xc0000061a0?)
705 | /src/vendor/github.com/spf13/cobra/command.go:992 +0x13
706 | main.main()
707 | /src/main.go:10 +0x18
708 |  
709 | [Container] 2023/10/25 23:04:14.209271 Command did not exit successfully bin/destroy --no-dry-run --force exit status 2
710 | [Container] 2023/10/25 23:04:14.212499 Phase complete: BUILD State: FAILED

This doesn't happen for all regions. It happens for us-east-1.

@sinisa229 sinisa229 requested a review from a team as a code owner October 26, 2023 14:59
@mtovino-nefeli
Copy link

I've observed the same error, thank you for the fix!

@bassjompi
Copy link

Im having the same issue, thanks a lot for the fix. Hope its merged soon

@SSKale1
Copy link

SSKale1 commented Oct 30, 2023

Faced a similar issue, thanks for the fix, also faced issues in other regions. (me-south-1, ap-southeast-1)

Copy link
Contributor

@kurtmc kurtmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue affects us too. Keen to see this get merged.

@tmax22
Copy link

tmax22 commented Sep 11, 2024

whats going on guys? i can see the issue is still open but this related pr was not merged upstream. i got the exact same issue (same error and error trace) on aws nuker v2.25.0. is it possible to merge?

@der-eismann
Copy link
Member

Hey everyone, please see the readme of the project for an updated status:

Caution

This repository for aws-nuke is no longer being actively maintained. We recommend users to switch to the actively maintained fork of this project at ekristen/aws-nuke.
We appreciate all the support and contributions we've received throughout the life of this project. We believe that the fork will continue to provide the functionality and support that you have come to expect from aws-nuke.
Please note that this deprecation means we will not be addressing issues, accepting pull requests, or making future releases from this repository.
Thank you for your understanding and support.

@ekristen
Copy link
Collaborator

@sinisa229 this issues has been fixed via ekristen/aws-nuke#15 and ekristen/aws-nuke#287.

@tmax22 looks like you had/have approval authority on this repository. If you are interested in continuing to contribute and review, please reach out!

Please see a copy of the notice from the README about the deprecation of this project. Sven was kind enough to grant me access to help triage and close issues and pull requests that have already been addressed in the actively maintained fork. Some additional information is located in the welcome issue for more information.

Caution

This repository for aws-nuke is no longer being actively maintained. We recommend users to switch to the actively maintained fork of this project at ekristen/aws-nuke.
We appreciate all the support and contributions we've received throughout the life of this project. We believe that the fork will continue to provide the functionality and support that you have come to expect from aws-nuke.
Please note that this deprecation means we will not be addressing issues, accepting pull requests, or making future releases from this repository.
Thank you for your understanding and support.

@ekristen ekristen closed this Sep 12, 2024
@tmax22
Copy link

tmax22 commented Sep 13, 2024

@ekristen I have no idea why I have approval authority on this repo. Most probably everyone one have.
Thank you for your awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants