Disable delete-protection for cognito user pool #993

suleman-sohail · 2023-05-07T11:24:55Z

On nuking aws account, having cognito user pool, as one of its resources, nuke fails to cleanup. deletionProtection support is added in remove method of cognito-user-pool.

farrukh-taqveem

Let's remove these un-necessary lines & spaces.
Rest Looks good.

farrukh-taqveem · 2023-05-08T06:09:13Z

pkg/config/config.go

@@ -47,6 +47,7 @@ type DisableDeletionProtection struct {
 	CloudformationStack bool `yaml:"CloudformationStack"`
 	ELBv2               bool `yaml:"ELBv2"`
 	QLDBLedger          bool `yaml:"QLDBLedger"`
+	CognitoUserPool 	bool `yaml:"CognitoUserPool"`


Suggested change

CognitoUserPool bool `yaml:"CognitoUserPool"`

CognitoUserPool bool `yaml:"CognitoUserPool"`

farrukh-taqveem · 2023-05-08T06:53:30Z

resources/cognito-userpools.go

 )

 type CognitoUserPool struct {
 	svc  *cognitoidentityprovider.CognitoIdentityProvider
 	name *string
 	id   *string
+


Suggested change

farrukh-taqveem · 2023-05-08T06:53:40Z

resources/cognito-userpools.go

+			return nil
+		}
+	}
+


Suggested change

npellegrin · 2023-07-20T15:28:18Z

Hello. I am also looking forward to have this feature in aws-nuke. Does this Merge request require additional fixes I can help with ?

npellegrin · 2023-07-20T16:10:50Z

References #989

suleman-sohail · 2023-07-25T17:28:59Z

Hello. I am also looking forward to have this feature in aws-nuke. Does this Merge request require additional fixes I can help with ?

Nope, I believe we are all set for the referenced issue, we can get this merged.

bjoernhaeuser · 2023-08-02T08:34:57Z

resources/cognito-userpools.go

+	if err != nil {
+		if f.featureFlags.DisableDeletionProtection.CognitoUserPool{
+			err = f.DisableProtection()
+			if err!=nil{


Can you please quickly run go fmt on these files?

der-eismann · 2023-08-02T08:36:40Z

resources/cognito-userpools.go

 	svc  *cognitoidentityprovider.CognitoIdentityProvider
 	name *string
 	id   *string
+	featureFlags config.FeatureFlags


Formatting is still off here. You should setup your IDE to use gofmt to automatically format files on save.

der-eismann · 2023-08-25T15:25:07Z

resources/cognito-userpools.go

+	}
+	userPool := userPoolOutput.UserPool
+	params := &cognitoidentityprovider.UpdateUserPoolInput{
+		DeletionProtection:     &cognitoidentityprovider.DeletionProtectionType_Values()[1],


Suggested change

DeletionProtection: &cognitoidentityprovider.DeletionProtectionType_Values()[1],

DeletionProtection: aws.String(cognitoidentityprovider.DeletionProtectionTypeInactive),

Using the constant here instead of accessing an array by numbers

der-eismann · 2023-08-25T15:26:22Z

resources/cognito-userpools.go

 	_, err := f.svc.DeleteUserPool(&cognitoidentityprovider.DeleteUserPoolInput{
 		UserPoolId: f.id,
 	})
+	if err != nil {
+		if f.featureFlags.DisableDeletionProtection.CognitoUserPool {


Suggested change

if f.featureFlags.DisableDeletionProtection.CognitoUserPool {

awsErr, ok := err.(awserr.Error)

if ok && strings.Contains(awsErr.Message(), "Deletion protection must be inactivated first") &&

f.featureFlags.DisableDeletionProtection.CognitoUserPool {

I'd prefer checking here if the error is actually caused by the Deletion Protection before proceeding

BrutalSimplicity · 2024-04-15T18:20:16Z

Ran into this issue today. It looks like this is pending some updates from the author @suleman-sohail. If they're unable to get to this, should a new PR be opened? It doesn't look like much is left here but some cosmetic changes.

suleman-sohail · 2024-04-19T15:34:24Z

Ran into this issue today. It looks like this is pending some updates from the author @suleman-sohail. If they're unable to get to this, should a new PR be opened? It doesn't look like much is left here but some cosmetic changes.

Hi, I could not reply anytime soon, thanks for waiting. I believe I was able to address the relevant comments, I might have miss something. You can create PR on child branch of this one, do any changes you think are needed for this PR to get merged, get that merged in this one, and we are good to go.

ekristen · 2024-09-26T21:57:26Z

This was implemented in the fork via this PR ekristen/aws-nuke#311 and is in 3.23.0 and forward.

If you have a chance, please check it out and let us know if you run into an issues by opening an issue over on the fork.

Please see the copy of the notice from the README about the deprecation of this project. Sven was kind enough to grant me access to help triage and close issues and pull requests that have already been addressed in the actively maintained fork. Some additional information is located in the welcome issue for more information.

Caution

This repository for aws-nuke is no longer being actively maintained. We recommend users to switch to the actively maintained fork of this project at ekristen/aws-nuke.
We appreciate all the support and contributions we've received throughout the life of this project. We believe that the fork will continue to provide the functionality and support that you have come to expect from aws-nuke.
Please note that this deprecation means we will not be addressing issues, accepting pull requests, or making future releases from this repository.
Thank you for your understanding and support.

Added Deletion protection disable feature in cognito user-pool

9932a40

suleman-sohail requested a review from a team as a code owner May 7, 2023 11:24

farrukh-taqveem reviewed May 8, 2023

View reviewed changes

suleman-sohail changed the title ~~Added disable feature for cognito-user-pool deletion protection~~ Disable delete-protection for cognito user pool May 8, 2023

Suleman Sohail added 4 commits May 8, 2023 12:10

Minor Changes

b4f6b52

nit

4a930f7

spaces

7de0972

spaces 2

b1feb6c

farrukh-taqveem approved these changes May 18, 2023

View reviewed changes

Suleman Sohail and others added 3 commits July 25, 2023 17:01

stopping executions

5936b4a

Merge branch 'rebuy-de:main' into main

ebff812

bad revert

1d463d5

bjoernhaeuser reviewed Aug 2, 2023

View reviewed changes

der-eismann reviewed Aug 2, 2023

View reviewed changes

Suleman Sohail and others added 2 commits August 13, 2023 16:54

Formatted

54db911

Merge branch 'main' into main

4ab7ce8

suleman-sohail requested review from bjoernhaeuser and der-eismann August 13, 2023 11:54

suleman-sohail and others added 3 commits August 21, 2023 13:20

Merge branch 'main' into main

8d56ff7

Merge branch 'main' into main

bd90c7e

Merge branch 'main' into main

49973c6

der-eismann requested changes Aug 25, 2023

View reviewed changes

der-eismann mentioned this pull request Aug 25, 2023

Disabling Remediation Configuration before deleting config rule #1001

Merged

der-eismann added the status/waiting-reponse Waiting for the issue author to respond to a question. label Aug 29, 2023

Suleman Sohail and others added 3 commits September 10, 2023 19:14

Validating error message

9ce66f1

Merge branch 'main' of https://github.com/suleman-sohail/aws-nuke

eca3ddf

Merge branch 'main' into main

d4cbbc2

Merge branch 'main' into main

1828ffc

suleman-sohail requested a review from der-eismann September 21, 2023 02:01

suleman-sohail added 4 commits September 24, 2023 22:58

Merge branch 'rebuy-de:main' into main

98a8d2e

Merge branch 'main' into main

b57aeed

Merge branch 'main' into main

37316a5

Merge branch 'main' into main

e40bf43

Merge branch 'main' into main

e24ef25

malc-moo approved these changes Sep 4, 2024

View reviewed changes

ekristen closed this Sep 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable delete-protection for cognito user pool #993

Disable delete-protection for cognito user pool #993

suleman-sohail commented May 7, 2023 •

edited

Loading

farrukh-taqveem left a comment

farrukh-taqveem May 8, 2023

farrukh-taqveem May 8, 2023

farrukh-taqveem May 8, 2023

npellegrin commented Jul 20, 2023

npellegrin commented Jul 20, 2023 •

edited

Loading

suleman-sohail commented Jul 25, 2023

bjoernhaeuser Aug 2, 2023

der-eismann Aug 2, 2023

der-eismann Aug 25, 2023

der-eismann Aug 25, 2023

BrutalSimplicity commented Apr 15, 2024

suleman-sohail commented Apr 19, 2024

ekristen commented Sep 26, 2024

	CognitoUserPool bool `yaml:"CognitoUserPool"`
	CognitoUserPool bool `yaml:"CognitoUserPool"`

	DeletionProtection: &cognitoidentityprovider.DeletionProtectionType_Values()[1],
	DeletionProtection: aws.String(cognitoidentityprovider.DeletionProtectionTypeInactive),

Disable delete-protection for cognito user pool #993

Disable delete-protection for cognito user pool #993

Conversation

suleman-sohail commented May 7, 2023 • edited Loading

farrukh-taqveem left a comment

Choose a reason for hiding this comment

farrukh-taqveem May 8, 2023

Choose a reason for hiding this comment

farrukh-taqveem May 8, 2023

Choose a reason for hiding this comment

farrukh-taqveem May 8, 2023

Choose a reason for hiding this comment

npellegrin commented Jul 20, 2023

npellegrin commented Jul 20, 2023 • edited Loading

suleman-sohail commented Jul 25, 2023

bjoernhaeuser Aug 2, 2023

Choose a reason for hiding this comment

der-eismann Aug 2, 2023

Choose a reason for hiding this comment

der-eismann Aug 25, 2023

Choose a reason for hiding this comment

der-eismann Aug 25, 2023

Choose a reason for hiding this comment

BrutalSimplicity commented Apr 15, 2024

suleman-sohail commented Apr 19, 2024

ekristen commented Sep 26, 2024

suleman-sohail commented May 7, 2023 •

edited

Loading

npellegrin commented Jul 20, 2023 •

edited

Loading