Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit comment manifest #280

Merged
merged 2 commits into from
Dec 24, 2023
Merged

commit comment manifest #280

merged 2 commits into from
Dec 24, 2023

Conversation

isamu
Copy link
Collaborator

@isamu isamu commented Dec 24, 2023

Generate commit comments from git diff.

Add hono

- Add a rewrite rule in firebase.json to route requests to the "/api/*" path to the "hono_server" function in the "asia-northeast1" region.
- Add the "hono" package as a dependency in the package.json file.
- Add a new file "hono.ts" in the "functions/src/functions/server" directory, which contains the implementation for the "hono_server" function.
- Update the "index.ts" file to export the "hono_server" function.
- Add a new file "hono.ts" in the "functions/src/wrappers/server" directory, which wraps the "hono_server" function with Firebase Functions configuration.

@isamu isamu requested a review from snakajima December 24, 2023 06:50
Copy link
Collaborator

@snakajima snakajima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title はこれで良いのかな?

@isamu
Copy link
Collaborator Author

isamu commented Dec 24, 2023

title更新忘れてました。
更新しました。

@isamu isamu merged commit 7f7ac52 into receptron:main Dec 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants