Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging to main: Dev container and small fixes #2166

Merged
merged 12 commits into from
Sep 11, 2024
Merged

Staging to main: Dev container and small fixes #2166

merged 12 commits into from
Sep 11, 2024

Conversation

miguelgfierro
Copy link
Collaborator

Description

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • I have signed the commits, e.g. git commit -s -m "your commit message".
  • This PR is being made to staging branch AND NOT TO main branch.

SimonYansenZhao and others added 12 commits August 27, 2024 18:45
* Update dev contaienr configuration

Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>

* Use conda to manage environments

Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>

* Set Python interpreter

Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>

* Update

Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>

* Add machine specs

Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>

---------

Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Fixed an issue where the incorrect variable `word_dict` was being dumped to word_dict_all.pkl instead of `word_dict_all` in the `mind_utils.ipynb` notebook.
Fixed an issue where the incorrect variable `word_dict` was being dumped to word_dict_all.pkl instead of `word_dict_all` in the `mind_utils.ipynb` notebook.

Signed-off-by: aaron <aaron_palpallatoc@dlsu.edu.ph>
Correct variable used in pickle dump in `mind_utils.ipynb`
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: David Davó <david@ddavo.me>
Signed-off-by: David Davó <david@ddavo.me>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@miguelgfierro miguelgfierro merged commit 83ebb5c into main Sep 11, 2024
85 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 11, 2024
Staging to main: Dev container and small fixes
github-actions bot pushed a commit to VinayaSathyanarayana/recommenders that referenced this pull request Sep 22, 2024
Staging to main: Dev container and small fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants