Minor changes to ArdOSC #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct some spelling errors, added BLOB support (on decode only currently)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I've been using ArdOSC for a while, and I just patched your latest version to get it to compile with the latest Arduino tool chain (and chipKIT32).
It wasn't compiling due to places where a return type of (for example) OSCMessage * was being referred to as OSCMessage::OSCMessage, which is an error since Classname::Classname refers to the constructor for Classname.
Here's the commit message:
Removed Classname::Classname when referencing Classname errors, corrected some spelling errors, added BLOB support (on decode only currently)
Thanks for your good work,
-Scott