Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pull Ansible Galaxy dependencies #7548

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from
Draft

Conversation

fridim
Copy link
Collaborator

@fridim fridim commented Dec 22, 2023

SUMMARY

We recently had a case where because of ansible galaxy collections listed as dependencies inside a collection, agnosticd replaced the collections already installed inside the Execution Environment (EE) image.

For example, if you add ansible.workshops in ansible/config/.../requirements.yml, you get amazon.aws version 3.1.1 instead of version 6.x that is normally included with the EE.

This occurs because the ansible.workshops collection specifies version 3.1.1 in its galaxy.yml file, as seen here: https://github.com/ansible/workshops/blob/devel/galaxy.yml#L56

That by-pass our process that ensures collections already installed in the EE are not overridden.

This is going to cause unpredictable issues and will be very hard to troubleshoot when it happens because the symptoms could be anything.
I think we want the list of dependencies to be exhaustive in the requirements.yml of the agnosticd config/.
I suggest we don't pull dependencies automatically.

This change will potentially break some deployment and will require to fix the requirements.yml and explicitly add the required galaxy collections.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

agnosticd core

@github-actions github-actions bot added the core label Dec 22, 2023
@tonykay
Copy link
Collaborator

tonykay commented Dec 22, 2023

Totally get the issue, I think we need great caution here. I assume this is an early 2024 thing so we have hands on deck if there are extensive implications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants