Fix sanity errors #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
alinabuzachis
force-pushed
the
fix_linting
branch
from
dd571bd
to
f837727
Compare
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
alinabuzachis
force-pushed
the
fix_linting
branch
from
09b01c1
to
f26c169
Compare
alinabuzachis
force-pushed
the
fix_linting
branch
from
f26c169
to
c4a9ce8
Compare
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
alinabuzachis
force-pushed
the
fix_linting
branch
5 times, most recently
from
bd8c0f7
to
9c83e98
Compare
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
alinabuzachis
force-pushed
the
fix_linting
branch
from
9c83e98
to
d4970c5
Compare
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
alinabuzachis
force-pushed
the
fix_linting
branch
from
efbfc97
to
9db614e
Compare
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
alinabuzachis
force-pushed
the
fix_linting
branch
2 times, most recently
from
eaac7a9
to
de85383
Compare
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
alinabuzachis
force-pushed
the
fix_linting
branch
from
de85383
to
648a205
Compare
alinabuzachis
force-pushed
the
fix_linting
branch
2 times, most recently
from
cc9bac4
to
dd1cbc1
Compare
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
alinabuzachis
force-pushed
the
fix_linting
branch
from
dd1cbc1
to
d86e852
Compare
hakbailey
reviewed
Aug 24, 2023
|
|
||
| self.fail_json( | ||
| msg="NatGateway Subnet {0} Network Acl Egress Rules do not allow outbound traffic to destination: {1} : {2}".format( | ||
| self.src_subnet_id, self.dst_ip, str(dst_port) |
There was a problem hiding this comment.
We can't use f-string formatting?
gravesm
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sanity errors