Merge pull request #90 from Yaish25491/ACA-1639_manage_security_group

ACA-1639 manage security group
redhat-cop · Jul 22, 2024 · 49a57f6 · 49a57f6
2 parents 31a8585 + c928488
commit 49a57f6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/changelogs/fragments/20240721-test_azure_manage_security_group.yml b/changelogs/fragments/20240721-test_azure_manage_security_group.yml
@@ -0,0 +1,2 @@
+bugfixes:
+  - Adding alwayes statment to the first block in test_azure_manage_security_group main to ensure security group deleted
diff --git a/tests/integration/targets/test_azure_manage_security_group/tasks/main.yml b/tests/integration/targets/test_azure_manage_security_group/tasks/main.yml
@@ -11,6 +11,13 @@
     ansible.builtin.include_tasks: "create_and_delete_sg.yml"
     vars:
       test_resource_group: "{{ resource_group }}"
+
+  always:
+    - name: Cleanup - make sure Security Group deleted - {{ security_group_name }}
+      azure.azcollection.azure_rm_securitygroup:
+        resource_group: "{{ resource_group }}"
+        name: "{{ security_group_name }}"
+        state: absent
 
 - name: Test with create and delete Resource Group
   block:
@@ -32,12 +39,6 @@
         azure_manage_security_group_delete_resource_group: true
 
   always:
-    - name: Cleanup - make sure Security Group deleted - {{ security_group_name }}
-      azure.azcollection.azure_rm_securitygroup:
-        resource_group: "{{ resource_group }}"
-        name: "{{ security_group_name }}"
-        state: absent
-
     - name: Cleanup - make sure Resource Group deleted - {{ new_resource_group }}
       azure.azcollection.azure_rm_resourcegroup:
         name: "{{ new_resource_group }}"