-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added andrew-jones and YoNoSoyVictor #915
Conversation
Both those users need to link their GitHub ID with LDAP, see: |
Hi, @garethahealy - we'll ask that they do that. In the mean-time, as an existing member, I can confirm that both of these are new team-members for our team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once they add their GitHub to LDAP
I can confirm that both Andrew and Victor have added the ID to rover now @djdanielsson |
ldapsearch is not showing for @andrew-jones:
It finds @YoNoSoyVictor |
Hi @garethahealy, can you check now please. I've updated rover. Thanks |
@garethahealy thanks for the merge. I'm still having issues pushing a new branch to the agnosticd repo. Any ideas if I have missed something?
|
@andrew-jones ; you should of got a github email to accept the invitation to join the org. you need to accept that. also, this PR didn't give you push writes to the agnosticd repo. it just added you to the org. if you want push, you'll need to be added to the team: |
Add users -Victor and Andrew