Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added andrew-jones and YoNoSoyVictor #915

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

bbethell-1
Copy link
Contributor

@bbethell-1 bbethell-1 commented Oct 3, 2024

Add users -Victor and Andrew

@bbethell-1 bbethell-1 requested a review from a team as a code owner October 3, 2024 12:32
@garethahealy
Copy link
Contributor

Both those users need to link their GitHub ID with LDAP, see:

@garethahealy garethahealy added access Permissions related to organization, repositories, or teams do-not-merge/work-in-progress labels Oct 3, 2024
@9strands
Copy link
Contributor

9strands commented Oct 3, 2024

Hi, @garethahealy - we'll ask that they do that. In the mean-time, as an existing member, I can confirm that both of these are new team-members for our team.

@garethahealy garethahealy changed the title Update config.yaml added andrew-jones and YoNoSoyVictor Oct 3, 2024
Copy link
Contributor

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once they add their GitHub to LDAP

@bbethell-1
Copy link
Contributor Author

I can confirm that both Andrew and Victor have added the ID to rover now @djdanielsson

@garethahealy
Copy link
Contributor

ldapsearch is not showing for @andrew-jones:

ldapsearch -x -h ldap.corp.redhat.com -b dc=redhat,dc=com -s sub 'rhatSocialURL=Github->*andrew-jones*'
# extended LDIF
#
# LDAPv3
# base <dc=redhat,dc=com> with scope subtree
# filter: rhatSocialURL=Github->*andrew-jones*
# requesting: ALL
#

# search result
search: 2
result: 0 Success

# numResponses: 1

It finds @YoNoSoyVictor

@andrew-jones
Copy link
Contributor

Hi @garethahealy, can you check now please. I've updated rover.

Thanks
Andrew

@garethahealy garethahealy merged commit c659be1 into redhat-cop:main Oct 10, 2024
2 checks passed
@andrew-jones
Copy link
Contributor

andrew-jones commented Oct 11, 2024

@garethahealy thanks for the merge. I'm still having issues pushing a new branch to the agnosticd repo. Any ideas if I have missed something?

andrew@fedora:~/src/github.com/redhat-cop/agnosticd$ git fetch -p
remote: Enumerating objects: 24, done.
remote: Counting objects: 100% (24/24), done.
remote: Compressing objects: 100% (12/12), done.
remote: Total 24 (delta 10), reused 18 (delta 10), pack-reused 0 (from 0)
Unpacking objects: 100% (24/24), 14.54 KiB | 1.45 MiB/s, done.
From github.com:redhat-cop/agnosticd
   403cb1d28..b700a3656  development -> origin/development
   803868996..2dfadc8bc  gh-pages    -> origin/gh-pages

andrew@fedora:~/src/github.com/redhat-cop/agnosticd$ git push origin andrew-jones-patch-1 
ERROR: Permission to redhat-cop/agnosticd.git denied to andrew-jones.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@garethahealy
Copy link
Contributor

garethahealy commented Oct 11, 2024

@andrew-jones ; you should of got a github email to accept the invitation to join the org. you need to accept that.
Screenshot 2024-10-11 at 08 08 45

also, this PR didn't give you push writes to the agnosticd repo. it just added you to the org. if you want push, you'll need to be added to the team:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
access Permissions related to organization, repositories, or teams do-not-merge/work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants