Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expression constant in contains #411

Merged
merged 11 commits into from
Oct 26, 2023

Conversation

zulander1
Copy link
Contributor

Fixes #409

@slorello89
Copy link
Member

@zulander1 - try with the updates I just made on your branch, think that ought to work. This is a pretty interesting usecase of Redis OM, one thing I noticed though was that it doesn't seem to issue any Select predicates if you don't request the full object - wonder what that's about?

@zulander1
Copy link
Contributor Author

zulander1 commented Sep 15, 2023

@zulander1 - try with the updates I just made on your branch, think that ought to work. This is a pretty interesting usecase of Redis OM, one thing I noticed though was that it doesn't seem to issue any Select predicates if you don't request the full object - wonder what that's about?

Yeah, there is an issue with the Select, but not with the predicates, it doesn't want to create a new instance of the object... I didn't have time to look into, will do this week; i'll let you know if the fix work for the constant issue!

@slorello89
Copy link
Member

@zulander1 - I'm assuming it's nothing on Redis OM's end? I just don't see anything in the predicates being pushed down to it.

@zulander1
Copy link
Contributor Author

zulander1 commented Sep 26, 2023

@slorello89 Wow it's working flawlessly! For the Select predicates we need to use UseProjection, i've updated the example

@vbedekar
Copy link

Any timeline when we can see this in a new release

Copy link
Member

@slorello89 slorello89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@slorello89 slorello89 merged commit ffb3a40 into redis:main Oct 26, 2023
1 check passed
@zulander1 zulander1 deleted the fix-expression-constant-in-contains branch October 26, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to Improve TranslateContainsStandardQuerySyntax to include Expression.Constant
3 participants