-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add couchbase processor #1596
Add couchbase processor #1596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, this looks great @sapk, just a minor comment on the docs but other than that it looks good to go.
Field(service.NewStringField("password").Description("Password to connect to the cluster.").Optional()). | ||
Field(service.NewStringField("bucket").Description("Couchbase bucket.")). | ||
Field(service.NewStringField("collection").Description("Bucket collection.").Default("_default").Advanced().Optional()). | ||
Field(service.NewStringAnnotatedEnumField("transcoder", map[string]string{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these transcoder descriptions were copy/pasted from the operation field and need updating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I totally forget to update it. Sorry.
It should be good now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sapk, looks great! I'm planning a release likely early next week.
This PR add a
couchbase
processor to do various action on key/value store.Later cache, output and maybe input (via n1ql) could be added.
The gocb library support tracing and metrics and could also later be implemented via wrapper.
Relate to: #364