Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add couchbase processor #1596

Merged
merged 5 commits into from
Dec 8, 2022
Merged

Conversation

sapk
Copy link
Contributor

@sapk sapk commented Dec 3, 2022

This PR add a couchbase processor to do various action on key/value store.

Later cache, output and maybe input (via n1ql) could be added.
The gocb library support tracing and metrics and could also later be implemented via wrapper.

Relate to: #364

@sapk sapk requested a review from Jeffail as a code owner December 3, 2022 20:12
Copy link
Collaborator

@Jeffail Jeffail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, this looks great @sapk, just a minor comment on the docs but other than that it looks good to go.

Field(service.NewStringField("password").Description("Password to connect to the cluster.").Optional()).
Field(service.NewStringField("bucket").Description("Couchbase bucket.")).
Field(service.NewStringField("collection").Description("Bucket collection.").Default("_default").Advanced().Optional()).
Field(service.NewStringAnnotatedEnumField("transcoder", map[string]string{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these transcoder descriptions were copy/pasted from the operation field and need updating.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I totally forget to update it. Sorry.
It should be good now.

Copy link
Collaborator

@Jeffail Jeffail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sapk, looks great! I'm planning a release likely early next week.

@Jeffail Jeffail merged commit 71cce71 into redpanda-data:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants