Record computation time #622
Open
+63
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Record computation time along with re-computation count
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d4f6f86:
|
|
Looks very interesting, can we disable during production mode? |
appmateeu
reviewed
Mar 30, 2024
| @@ -46,6 +46,14 @@ export function setInputStabilityCheckEnabled(enabled: StabilityCheck) { | |||
| globalStabilityCheck = enabled | |||
| } | |||
|
|
|||
| function getTime() { | |||
There was a problem hiding this comment.
I am wondering if wouldn't be better if definition of getTime would look like:
const getTime = performance && typeof performance.now === 'function'
? performance.now.bind(performance)
: Date.now.bind(Date)In that case no extra conditions or jumps will be done while the function executes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Currently, I'm using
recomputationscount to verify the performance of our selectors in local environment. This gave us a lot of insights into how we implemented the selectors. Besides the re-computation count, I'd like to know more about how long is the execution/computation time as well. Therefore I create this PR for this change. Hope it would be helpful for everyone.Sorry if I didn’t follow any guidelines, this is the first time I submit PR.
Thank you.