Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate type tests to Vitest #697

Open
wants to merge 58 commits into
base: master
Choose a base branch
from
Open

Migrate type tests to Vitest #697

wants to merge 58 commits into from

Commits on Sep 17, 2024

  1. Remove unnecessary include and typecheck from vitest.config.mts

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    41f8645 View commit details
    Browse the repository at this point in the history

  2. Rename test/tsconfig.json to tsconfig.test.json

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    3da8b97 View commit details
    Browse the repository at this point in the history

  3. Revamp type tests config

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a3b5c6e View commit details
    Browse the repository at this point in the history

  4. Update CI to include correct tsconfig

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    e718860 View commit details
    Browse the repository at this point in the history

  5. Fix testTypes import

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2367961 View commit details
    Browse the repository at this point in the history

  6. Convert assertType usages to .toEqualTypeOf calls

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5d8151c View commit details
    Browse the repository at this point in the history

  7. Simplify type tests in createStructuredSelector.withTypes.test-d.ts

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    418dceb View commit details
    Browse the repository at this point in the history

  8. Simplify the type tests in createStructuredSelector.test-d.ts

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    8504022 View commit details
    Browse the repository at this point in the history

  9. Simplify the type tests inside createSelector.withTypes.test-d.ts

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a9e1bef View commit details
    Browse the repository at this point in the history

  10. Add more meaningful assertions to deepNesting.test-d.ts

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    16dd2ed View commit details
    Browse the repository at this point in the history

  11. Remove expectType and expectExactType

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    23e991d View commit details
    Browse the repository at this point in the history

  12. Remove argsMemoize.typetest.ts file

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5af2f31 View commit details
    Browse the repository at this point in the history

  13. Replace expectExactType calls with expectTypeOf().toEqualTypeOf()

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    c041ec6 View commit details
    Browse the repository at this point in the history

  14. Remove duplicate tests for typedStructuredSelectorCreator

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d3be62c View commit details
    Browse the repository at this point in the history

  15. Convert functions and lone-blocks to test blocks

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d426d2c View commit details
    Browse the repository at this point in the history

  16. Move test.ts into type-tests folder

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4aeea48 View commit details
    Browse the repository at this point in the history

  17. Remove typesTestUtils.ts as it is no longer needed

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    91203e0 View commit details
    Browse the repository at this point in the history

  18. Update test command in package.json to use yarn bin vitest

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    187bf5f View commit details
    Browse the repository at this point in the history

  19. Fix test:typescript command

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    7cd1179 View commit details
    Browse the repository at this point in the history

  20. Rename test:typescript command to type-tests 

    - Rename `test:typescript` command to `type-tests` in `package.json` to be more consistent with RTK.
    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    6c42f2e View commit details
    Browse the repository at this point in the history

  21. Fix imports inside test files

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    37b3fb8 View commit details
    Browse the repository at this point in the history

  22. Fix type issues in createSelector.withTypes.test-d.ts

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a62c7da View commit details
    Browse the repository at this point in the history

  23. Add tsconfig.vitest-temp.json to .gitignore file

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    c8f7cd3 View commit details
    Browse the repository at this point in the history

  24. Move "nested selector" type test to deepNesting.test-d.ts

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    8f88ac3 View commit details
    Browse the repository at this point in the history

  25. Move lruMemoize type tests into its own file

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    448c238 View commit details
    Browse the repository at this point in the history

  26. Move createSelectorCreator type tests into its own file

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    6ecbde6 View commit details
    Browse the repository at this point in the history

  27. Remove duplicatecreateStructuredSelector.withTypes() type tests

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    0b27be9 View commit details
    Browse the repository at this point in the history

  28. Move createStructuredSelector type tests into its own file

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d5217f7 View commit details
    Browse the repository at this point in the history

  29. Move createSelector type tests into its own file

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    910fe9d View commit details
    Browse the repository at this point in the history

  30. Move some more lruMemoize type tests into its own file

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    9b5b733 View commit details
    Browse the repository at this point in the history

  31. Move some more createSelectorCreator type tests into its own file

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    6ed0e71 View commit details
    Browse the repository at this point in the history

  32. Move type tests inside test.ts into their respective files

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    922bf4b View commit details
    Browse the repository at this point in the history

  33. Remove test.ts

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    52a7863 View commit details
    Browse the repository at this point in the history

  34. Make describe titles more consistent across type tests

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a4f0059 View commit details
    Browse the repository at this point in the history

  35. De-duplicate AnyFunction definitions

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5bc347a View commit details
    Browse the repository at this point in the history

  36. Fix type issues in scripts/writeGitVersion.mjs

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    e122b87 View commit details
    Browse the repository at this point in the history

  37. Rename setup.vitest.ts to setup.ts

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2bca06c View commit details
    Browse the repository at this point in the history

  38. Change setupFiles to ['test/setup.ts']

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    118f868 View commit details
    Browse the repository at this point in the history

  39. Replace references of typescript_test to type-tests

    @aryaemami59
    aryaemami59 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2f2ede7 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Remove Node ESM setup from vitest.config.mts

    @aryaemami59
    aryaemami59 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    4857c28 View commit details
    Browse the repository at this point in the history

  2. Provide the correct tsconfig file to tsup

    @aryaemami59
    aryaemami59 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    50bd1d6 View commit details
    Browse the repository at this point in the history

  3. Add yalc to .gitignore

    @aryaemami59
    aryaemami59 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    0916b42 View commit details
    Browse the repository at this point in the history

  4. Run both runtime and type tests against the dist folder during CI

    @aryaemami59
    aryaemami59 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    818c7e6 View commit details
    Browse the repository at this point in the history

  5. Remove dead code from computationComparisons.spec.tsx 

      - There were multiple `store.dispatch` calls that were not needed. These were removed to clean up the test file and speed up execution of tests.
    @aryaemami59
    aryaemami59 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    4a522f8 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary test from computationComparisons.spec.tsx 

      - This was done mainly to speed up executions of unit tests.
    @aryaemami59
    aryaemami59 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    2e42780 View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary async keyword

    @aryaemami59
    aryaemami59 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    3a04f9a View commit details
    Browse the repository at this point in the history

  8. Fix some issues that were left over from the switch to weakMapMemoize 

    - Looks like some of the code in `computationComparisons.spec.tsx` wasn't properly updated after we switched the default memoization function from `lruMemoize` to `weakMapMemoize`. These have been updated to their correct implementations.
- Correct residual naming inconsistencies from the previous `defaultMemoize` to `lruMemoize` renaming. All references to `default` have been updated to `lru`.
    @aryaemami59
    aryaemami59 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    e6db620 View commit details
    Browse the repository at this point in the history

  9. Disable watch by default

    @aryaemami59
    aryaemami59 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    af9a468 View commit details
    Browse the repository at this point in the history

  10. Migrate type tests in lruMemoize.test-d.ts to Vitest

    @aryaemami59
    aryaemami59 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    aec409e View commit details
    Browse the repository at this point in the history

  11. Migrate some assertions in createSelectorCreator.test-d.ts to Vitest

    @aryaemami59
    aryaemami59 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    2fe9ffd View commit details
    Browse the repository at this point in the history

  12. Migrate some assertions in createSelector.test-d.ts to Vitest

    @aryaemami59
    aryaemami59 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    0eb2ca5 View commit details
    Browse the repository at this point in the history

  13. Migrate some assertions in createSelector.test-d.ts to Vitest

    @aryaemami59
    aryaemami59 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    f000321 View commit details
    Browse the repository at this point in the history

  14. Migrate the rest of the type tests in argsMemoize.test-d.ts to Vitest

    @aryaemami59
    aryaemami59 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6413a9c View commit details
    Browse the repository at this point in the history

  15. Set pool to threads for performance tests

    @aryaemami59
    aryaemami59 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c068d89 View commit details
    Browse the repository at this point in the history

  16. Remove esbuild from resolutions field

    @aryaemami59
    aryaemami59 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    ebbd49c View commit details
    Browse the repository at this point in the history

  17. Silence console output by disabling identityFunctionCheck

    @aryaemami59
    aryaemami59 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    9f531d1 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Bump vitest to version 2.1.5

    @aryaemami59
    aryaemami59 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    b8107e3 View commit details
    Browse the repository at this point in the history

  2. Add @types/node to devDependencies

    @aryaemami59
    aryaemami59 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a1804e0 View commit details
    Browse the repository at this point in the history