adding optional field for FieldColumns #124
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-lc
requested changes
Nov 13, 2024
common/messages.go
Outdated
| @@ -40,6 +40,9 @@ type View struct { | |||
| Name string `json:"name" msgpack:"name"` | |||
| LayoutType string `json:"layout_type" msgpack:"layout_type"` | |||
| DefaultRequests []string `json:"default_requests" msgpack:"default_requests"` | |||
|
|
|||
| // optional UI view settins: more exist on FE "LayoutOptions" but aren't all exposed via schema | |||
| FieldColumns int `json:"field_columns" msgpack:"field_columns"` | |||
There was a problem hiding this comment.
@oklex looks good, but if you want to omit the return values if there is no value lets do this and that should ensure we don't return a empty value to frontend
FieldColumns int json:"field_columns,omitempty" msgpack:"field_columns,omitempty"
josh-lc
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The plan was always to reveal more optional fields into the extensions UI that a back-end developer could use as needed, and a field for number of columns seems like it would be relevant for git-sync.
@josh-lc could I ask you to sanity check that this simple commit will accurately allow for an optional field to be added onto all schemas? I don't want this field to ever show up as an empty value on the schema if it can be helped because I think that gives the impression that it needs a value and it really doesn't.
For context, this field is typically auto-determined on the front-end and we would basically just be adding a field to the schema to override this value.
Type of change
Related issues
Fix refractionPOINT/tracking#1