Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH rattler #37

Merged
merged 42 commits into from
Jun 6, 2024
Merged

ENH rattler #37

merged 42 commits into from
Jun 6, 2024

Conversation

beckermr
Copy link
Contributor

@beckermr beckermr commented Jun 1, 2024

To do:

closes #19

@wolfv
Copy link
Contributor

wolfv commented Jun 2, 2024

This is cool. Please let us know if you find anything that's wrong with rattler :) 🚀

@beckermr beckermr marked this pull request as ready for review June 6, 2024 13:18
@beckermr
Copy link
Contributor Author

beckermr commented Jun 6, 2024

@wolfv @jaimergp This PR is ready to merge. A few notes.

  • I punted on the .solv files with mamba since rattler appears to be working with the test suite here. That is pretty non-trivial actually. The test suite here covers some very complicated feedstocks (arrow-cpp) and depends on properly interpreting run_constrains and virtual packages.
  • I did not use the built-in rattler virtual package functionality and am instead writing them as a channel on disk. This means we can use the same code with mamba.
  • The timeouts appear to be working with rattler.
  • rattler appears to be caching repodata very well
  • The timing for the test suite comes in with rattler about 10x faster. IDK if this is the solver, the metadata loading, or both.
  • I disabled the mamba test suite and made it not required. When we added support for run_constrains to the solver, it increased the test suite run time from ~20 minutes to ~1 hour which is a lot.

Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
@wolfv
Copy link
Contributor

wolfv commented Jun 6, 2024

Thank you @beckermr for pushing this through. This is an awesome test for resolvo and it's good to know that it works!

Also happy that we can make use of the features that we added to resolvo especially for these cases (timeout etc.) :)

@beckermr beckermr merged commit e3c910a into main Jun 6, 2024
3 checks passed
@beckermr beckermr deleted the rattler-maybe branch June 6, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants