fix minor logic issue

regulatory-genomics · Oct 22, 2024 · 741e4a7 · 741e4a7
1 parent 8117d28
commit 741e4a7
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/precellar/src/barcode.rs b/precellar/src/barcode.rs
@@ -243,23 +243,24 @@ impl Whitelist {
     }
 
     pub fn mean_base_quality_score(&self) -> f64 {
-        if self.total_base_count <= 0 {
+        if self.total_base_count == 0 {
+            // u64 never < 0
             0.0
         } else {
             self.base_qual_sum as f64 / self.total_base_count as f64
         }
     }
 
     pub fn frac_q30_bases(&self) -> f64 {
-        if self.total_base_count <= 0 {
+        if self.total_base_count == 0 {
             0.0
         } else {
             self.q30_base_count as f64 / self.total_base_count as f64
         }
     }
 
     pub fn frac_exact_match(&self) -> f64 {
-        if self.total_count <= 0 {
+        if self.total_count == 0 {
             0.0
         } else {
             1.0 - (self.mismatch_count as f64 / self.total_count as f64)