-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Self-issue Internet PKI certificate for gRPC server #44
Conversation
app/src/main/java/tech/relaycorp/cogrpc/server/TLSCertificateGenerator.kt
Show resolved
Hide resolved
app/src/main/java/tech/relaycorp/cogrpc/server/TLSCertificateGenerator.kt
Show resolved
Hide resolved
app/src/main/java/tech/relaycorp/cogrpc/server/TLSCertificateGenerator.kt
Outdated
Show resolved
Hide resolved
In addition to the changes requested, I also implemented a change to use the correct IP address when issuing the certificate instead of the hardcoded See: 4e902ca. I'd appreciate your feedback on that change too. |
@sdsantos, I had to make a change after the rebase (541252d). Can you please check it out when you get a chance? I hate having to use an external dependency just to do base64 encoding so I'm seriously considering switching to the raw binary serialisation in the near future (AwalaApp/specs#61). |
🎉 This PR is included in version 1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Fixes #36
Adding Bouncy Castle introduces many Lint violation warnings like:
There are a bunch of solutions here: https://stackoverflow.com/questions/60598110/meta-inf-versions-9-module-info-class-broken-class-file-this-feature-requires -- any preference? I don't like any -- it seems like a matter of picking a poison.