Merge pull request #17 from thcyron/fix-any

Handle slog.Any as string otel attributes
remychantenay · Jul 9, 2024 · a7d80f5 · a7d80f5
2 parents 79b008e + 40f2258
commit a7d80f5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/slog_otel.go b/slog_otel.go
@@ -212,7 +212,7 @@ func (h OtelHandler) slogAttrToOtelAttr(attr slog.Attr, groupKeys ...string) att
 		case []bool:
 			return attribute.BoolSlice(key, v)
 		default:
-			return attribute.KeyValue{}
+			return attribute.String(key, fmt.Sprintf("%+v", v))
 		}
 	default:
 		return attribute.KeyValue{}

diff --git a/slog_otel_test.go b/slog_otel_test.go
@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"context"
 	"encoding/json"
+	"errors"
 	"log/slog"
 	"strings"
 	"testing"
@@ -127,6 +128,9 @@ func TestOtelHandler(t *testing.T) {
 		}, {
 			Key:   "group_2.key_2",
 			Value: attribute.StringValue("value_2"),
+		}, {
+			Key:   "err",
+			Value: attribute.StringValue("boom"),
 		}}
 
 		func() {
@@ -151,6 +155,7 @@ func TestOtelHandler(t *testing.T) {
 				"float64_slice", float64Slice,
 				"bool_slice", boolSlice,
 				"a_key", "a_value",
+				"err", errors.New("boom"),
 				group1,
 				group2,
 			)