Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add promise interface #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add promise interface #137

wants to merge 1 commit into from

Conversation

hekike
Copy link
Member

@hekike hekike commented Oct 10, 2017

  • Add promise interface to StringClient and JsonClient

@hekike hekike force-pushed the feat/promise-interface branch 3 times, most recently from 8dd9b80 to 230d989 Compare October 11, 2017 15:31
@coveralls
Copy link

coveralls commented Oct 11, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 84.527% when pulling 230d989 on feat/promise-interface into bbdeb79 on master.

@hekike hekike force-pushed the feat/promise-interface branch from 230d989 to 10b5b03 Compare October 11, 2017 15:53
@hekike hekike force-pushed the feat/promise-interface branch from 10b5b03 to de08857 Compare October 11, 2017 15:57
@coveralls
Copy link

coveralls commented Oct 11, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.4%) to 84.399% when pulling 230d989 on feat/promise-interface into bbdeb79 on master.

@hekike
Copy link
Member Author

hekike commented Oct 11, 2017

I think this coverage change is a lie...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonutEspresso DonutEspresso Awaiting requested review from DonutEspresso

@yunong yunong Awaiting requested review from yunong

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hekike @coveralls