Skip to content

Commit

Permalink
Fix terminal-in-react TypeScript bug
Browse files Browse the repository at this point in the history
  • Loading branch information
retr00exe committed Feb 21, 2021
1 parent 83acf29 commit 8be92b2
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ Check out our [Next.js deployment documentation](https://nextjs.org/docs/deploym
- [ ] Navbar logo and darkmode toogle unresponsive on small devices. Can be solved by specifying the correct padding and margin or make flexbox container (I think)
- [ ] Lighthouse performance bug caused by next/Image (Ref: [Lighthouse](https://github.com/GoogleChrome/lighthouse/issues/11631) & [Next.js](https://github.com/vercel/next.js/issues/20611))
- [ ] Translating the page using Microsoft Edge causing card to overflow (`pages/index.tsx`)
- [ ] `terminal-in-react@4.3.1` can't provide TypeScript props to component

## To Do List 👀

Expand Down
2 changes: 2 additions & 0 deletions components/About.tsx → components/About.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ class AboutContent extends Component {
skills: this.skills,
}}
msg="Hi! Welcome to about page - Type 'help' to list all supported commands"
closedTitle=""
closedMessage="Click on the icon to reopen"
/>
</div>
</AboutWrapper>
Expand Down
2 changes: 1 addition & 1 deletion pages/post/[slug].tsx
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export default function Post({ post }: Post): JSX.Element {
<DiscussionEmbed
shortname="mekelilyasa"
config={{
url: `http://localhost:3000/post/${post.slug}`,
url: `https://mekelilyasa.now.sh/post/${post.slug}`,
identifier: post.slug,
title: post.title,
}}
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@
"isolatedModules": true,
"jsx": "preserve"
},
"include": ["next-env.d.ts", "**/*.ts", "**/*.tsx"],
"include": ["next-env.d.ts", "**/*.ts", "**/*.tsx", "components/About.jsx"],
"exclude": ["node_modules"]
}

1 comment on commit 8be92b2

@vercel
Copy link

@vercel vercel bot commented on 8be92b2 Feb 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.