Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor tweaks to site header for a11y #181

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

minor tweaks to site header for a11y #181

wants to merge 1 commit into from

Conversation

juruwolfe
Copy link

What's in this pull request

At the request of our accessibility experts, made a couple minor tweaks to the header. Added a destination to the logo (easy) and then added the skip link. For that one to work as intended, we'll need a minor change to the bluprint where our <main> tag has an id of #main-content

Copy link

changeset-bot bot commented Oct 14, 2024

⚠️ No Changeset found

Latest commit: d21cd1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@hobbes7878 hobbes7878 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a PR in #182 that adds the id to the main tag in Article component (and also cleared out the yarn.lock file (I switched this repo to npm a bit ago)).

Otherwise, just needs a changeset on the PR to make a new version. Can make one by running: npx changeset add. This would be a patch update, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants