Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AISDK-236: RevAiJobOptions does not support speakers_count param #262

Merged
merged 3 commits into from
Jun 21, 2024
Merged

AISDK-236: RevAiJobOptions does not support speakers_count param #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86ddef4
AISDK-236: RevAiJobOptions does not support speakers_count param
kirillatrev Jun 17, 2024
31e5124
fixup
kirillatrev Jun 17, 2024
ecd0197
Version bump
kirillatrev Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "revai-node-sdk",
"version": "3.8.5",
"version": "3.8.6",
"description": "Rev AI makes speech applications easy to build!",
"main": "src/index.js",
"scripts": {
Expand Down
1 change: 1 addition & 0 deletions src/models/RevAiApiJob.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export interface RevAiApiJob {
filter_profanity?: boolean;
custom_vocabulary_id?: string;
speaker_channels_count?: number;
speakers_count?: number;
language?: string;
transcriber?: string;
verbatim?: boolean;
Expand Down
1 change: 1 addition & 0 deletions src/models/async/RevAiJobOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export interface RevAiJobOptions {
skip_postprocessing?: boolean;
diarization_type?: string;
speaker_channels_count?: number;
speakers_count?: number;
custom_vocabulary_id?: string;
custom_vocabularies?: CustomVocabulary[];
filter_profanity?: boolean;
Expand Down
5 changes: 4 additions & 1 deletion test/unit/api-client/api-client.submit.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ describe('api-client job submission', () => {
const jobDetails = {
id: jobId,
status: 'in_progress',
created_on: '2018-05-05T23:23:22.29Z'
created_on: '2018-05-05T23:23:22.29Z',
speakers_count: 123
};
const filename = 'path/to/test.mp3';

Expand Down Expand Up @@ -88,6 +89,7 @@ describe('api-client job submission', () => {
skip_punctuation: true,
skip_diarization: true,
speaker_channels_count: 1,
speakers_count: 123,
filter_profanity: true,
media_url: mediaUrl,
remove_disfluencies: true,
Expand Down Expand Up @@ -173,6 +175,7 @@ describe('api-client job submission', () => {
skip_punctuation: true,
skip_diarization: true,
speaker_channels_count: 1,
speakers_count: 123,
filter_profanity: true,
remove_disfluencies: true,
delete_after_seconds: 0,
Expand Down
Loading