Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added input for fail-level reviewdog flag to later replace deprecated fail-on-error reviewdog flag #124

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

Bilka2
Copy link
Contributor

@Bilka2 Bilka2 commented Sep 19, 2024

To adapt for the same change in the reviewdog 0.20.2, see reviewdog/reviewdog#1854.

@haya14busa
Copy link
Member

Please keep the existing action input for backwards compatibility.

@Bilka2
Copy link
Contributor Author

Bilka2 commented Oct 12, 2024

Done 👍

@Bilka2 Bilka2 changed the title Replace deprecated fail-on-error reviewdog flag with fail-level Added input for fail-level reviewdog flag to later replace deprecated fail-on-error reviewdog flag Nov 9, 2024
Copy link
Member

@shmokmt shmokmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bilka2
I suggested some changes.
Could you check it?

README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Show resolved Hide resolved
@Bilka2
Copy link
Contributor Author

Bilka2 commented Nov 26, 2024

I've updated the files to include both suggestions 👍

@massongit massongit requested a review from shmokmt November 26, 2024 23:33
@massongit massongit merged commit ef7ea43 into reviewdog:master Dec 2, 2024
8 checks passed
Copy link
Contributor

github-actions bot commented Dec 2, 2024

🚀 [bumpr] Bumped! New version:v2.20.0 Changes:v2.19.1...v2.20.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants