feat!: provide onError, onComment, and onRetry callbacks
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The parser now takes an object of callbacks instead of an `onParse` callback. This means you do not have to check the type of the event in the `onEvent` callback, but instead provide separate callbacks for each event type. BREAKING CHANGE: The `ParsedEvent` type has been renamed to `EventSourceMessage` and the `type` attribute has been removed. BREAKING CHANGE: The `EventSourceCallback` type has been removed in favor of the `ParserCallbacks` interface. BREAKING CHNAGE: The `ReconnectInterval` type has been removed in favor of providing the interval directly to the `onRetry` callback. BREAKING CHANGE: The `ParseEvent` type has been removed in favor of providing separate callbacks for each event type. BREAKING CHANGE: The parser has been rewritten to be more specification compliant. Certain _rare_ edge cases may now be handled differently. Mixed CRLF and LF line endings will now be handled correctly. `retry` fields now have to be completely valid integers to be parsed.
rexxars
force-pushed
the
feat/parser-callbacks
branch
from
d76aeb9 to
2127326
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The parser now takes an object of callbacks instead of an
onParsecallback. This means you do not have to check the type of the event in theonEventcallback, but instead provide separate callbacks for each event type.BREAKING CHANGE: The
ParsedEventtype has been renamed toEventSourceMessageand thetypeattribute has been removed.BREAKING CHANGE: The
EventSourceCallbacktype has been removed in favor of theParserCallbacksinterface.BREAKING CHNAGE: The
ReconnectIntervaltype has been removed in favor of providing the interval directly to theonRetrycallback.BREAKING CHANGE: The
ParseEventtype has been removed in favor of providing separate callbacks for each event type.BREAKING CHANGE: The parser has been rewritten to be more specification compliant. Certain rare edge cases may now be handled differently. Mixed CRLF and LF line endings will now be handled correctly.
retryfields now have to be completely valid integers to be parsed.