Version 1.9.3 (#5485)

* Version 1.9.3 * Updated to latest master
rh-hideout · Oct 8, 2024 · a76f7fe · a76f7fe
1 parent efad9a3
commit a76f7fe
Show file tree

Hide file tree

Showing 19 changed files with 317 additions and 27 deletions.
diff --git a/.github/ISSUE_TEMPLATE/01_battle_engine_bugs.yaml b/.github/ISSUE_TEMPLATE/01_battle_engine_bugs.yaml
@@ -23,9 +23,10 @@ body:
       label: Version
       description: What version of pokeemerald-expansion are you using as a base?
       options:
-        - 1.9.2 (Latest release)
+        - 1.9.3 (Latest release)
         - master (default, unreleased bugfixes)
         - upcoming (Edge)
+        - 1.9.2
         - 1.9.1
         - 1.9.0
         - 1.8.6

diff --git a/.github/ISSUE_TEMPLATE/02_battle_ai_issues.yaml b/.github/ISSUE_TEMPLATE/02_battle_ai_issues.yaml
@@ -23,9 +23,10 @@ body:
       label: Version
       description: What version of pokeemerald-expansion are you using as a base?
       options:
-        - 1.9.2 (Latest release)
+        - 1.9.3 (Latest release)
         - master (default, unreleased bugfixes)
         - upcoming (Edge)
+        - 1.9.2
         - 1.9.1
         - 1.9.0
         - 1.8.6

diff --git a/.github/ISSUE_TEMPLATE/04_other_errors.yaml b/.github/ISSUE_TEMPLATE/04_other_errors.yaml
@@ -23,9 +23,10 @@ body:
       label: Version
       description: What version of pokeemerald-expansion are you using as a base?
       options:
-        - 1.9.2 (Latest release)
+        - 1.9.3 (Latest release)
         - master (default, unreleased bugfixes)
         - upcoming (Edge)
+        - 1.9.2
         - 1.9.1
         - 1.9.0
         - 1.8.6

diff --git a/README.md b/README.md
@@ -9,7 +9,7 @@ pokeemerald-expansion is a decomp hack base project based off pret's [pokeemeral
 If you use pokeemerald-expansion in your hack, please add RHH (Rom Hacking Hideout) to your credits list. Optionally, you can list the version used, so it can help players know what features to expect.
 You can phrase it as the following:
 ```
-Based off RHH's pokeemerald-expansion 1.9.2 https://github.com/rh-hideout/pokeemerald-expansion/
+Based off RHH's pokeemerald-expansion 1.9.3 https://github.com/rh-hideout/pokeemerald-expansion/
 ```
 
 ## What features are included?
@@ -178,7 +178,7 @@ With this, you'll get the latest version of pokeemerald-expansion, plus a couple
 - Check your current version.
     - You can check in the debug menu's `Utilities -> Expansion Version` option.
     - If the option is not available, you possibly have version 1.6.2 or older. In that case, please check the [changelogs](CHANGELOG.md) to determine your version based on the features available on your repository.
-- Once you have your remote set up, run the command `git pull RHH expansion/X.Y.Z`, replacing X, Y and Z with the digits of the respective version you want to update to (eg, to update to 1.9.2, use `git pull RHH expansion/1.9.2`).
+- Once you have your remote set up, run the command `git pull RHH expansion/X.Y.Z`, replacing X, Y and Z with the digits of the respective version you want to update to (eg, to update to 1.9.3, use `git pull RHH expansion/1.9.3`).
     - ***Important:*** If you are several versions behind, we recommend updating one minor version at a time, skipping directly to the latest patch version (eg, 1.5.3 -> 1.6.2 -> 1.7.4 and so on)
 - Alternatively, you can update to unreleased versions of the expansion.
     - ***master (stable):*** It contains unreleased **bugfixes** that will come in the next patch version. To merge, use `git pull RHH master`.

diff --git a/docs/SUMMARY.md b/docs/SUMMARY.md
@@ -5,20 +5,21 @@
     - [Setting up WSL1 (Legacy Portion)](./legacy_WSL1_INSTALL.md)
 - [Run documentation site locally](local_mdbook/index.md)
     - [Ubuntu WSL1/WSL2](local_mdbook/ubuntu_WSL.md)
-- [AI Flags](./ai_flags.md)
 - [Tutorials]()
-  - [How to add new AI Flags](./ai_logic.md)
-  - [How to add new battle script commands/macros](./how_to_battle_script_command_macro.md)
-  - [How to add a new move](./how_to_new_move.md)
-  - [How to add a new trainer class](./how_to_trainer_class.md)
+  - [What are AI Flags?](tutorials/ai_flags.md)
+    - [How to add new AI Flags](tutorials/ai_logic.md)
+  - [How to add new battle script commands/macros](tutorials/how_to_battle_script_command_macro.md)
+  - [How to add a new move](tutorials/how_to_new_move.md)
+  - [How to add a new trainer class](tutorials/how_to_trainer_class.md)
   - [How to add a new Pokémon]()
-    - [v1.9.x](./how_to_new_pokemon_1_9_0.md)
-    - [v1.8.x](./how_to_new_pokemon_1_8_0.md)
-    - [v1.7.x](./how_to_new_pokemon_1_7_0.md)
-    - [v1.6.x](./how_to_new_pokemon_1_6_0.md)
-  - [How to use the Testing System](./how_to_testing_system.md)
+    - [v1.9.x](tutorials/how_to_new_pokemon_1_9_0.md)
+    - [v1.8.x](tutorials/how_to_new_pokemon_1_8_0.md)
+    - [v1.7.x](tutorials/how_to_new_pokemon_1_7_0.md)
+    - [v1.6.x](tutorials/how_to_new_pokemon_1_6_0.md)
+  - [How to use the Testing System](tutorials/how_to_testing_system.md)
 - [Changelog](./CHANGELOG.md)
     - [1.9.x]()
+        - [Version 1.9.3](changelogs/1.9.x/1.9.3.md)
         - [Version 1.9.2](changelogs/1.9.x/1.9.2.md)
         - [Version 1.9.1](changelogs/1.9.x/1.9.1.md)
         - [Version 1.9.0](changelogs/1.9.x/1.9.0.md)
@@ -30,43 +31,36 @@
         - [Version 1.8.2](changelogs/1.8.x/1.8.2.md)
         - [Version 1.8.1](changelogs/1.8.x/1.8.1.md)
         - [Version 1.8.0](changelogs/1.8.x/1.8.0.md)
-
     - [1.7.x]()
         - [Version 1.7.4](changelogs/1.7.x/1.7.4.md)
         - [Version 1.7.3](changelogs/1.7.x/1.7.3.md)
         - [Version 1.7.2](changelogs/1.7.x/1.7.2.md)
         - [Version 1.7.1](changelogs/1.7.x/1.7.1.md)
         - [Version 1.7.0](changelogs/1.7.x/1.7.0.md)
-
     - [1.6.x]()
         - [Version 1.6.2](changelogs/1.6.x/1.6.2.md)
         - [Version 1.6.1](changelogs/1.6.x/1.6.1.md)
         - [Version 1.6.0](changelogs/1.6.x/1.6.0.md)
-
     - [1.5.x]()
         - [Version 1.5.3](changelogs/1.5.x/1.5.3.md)
         - [Version 1.5.2](changelogs/1.5.x/1.5.2.md)
         - [Version 1.5.1](changelogs/1.5.x/1.5.1.md)
         - [Version 1.5.0](changelogs/1.5.x/1.5.0.md)
-
     - [1.4.x]()
         - [Version 1.4.3](changelogs/1.4.x/1.4.3.md)
         - [Version 1.4.2](changelogs/1.4.x/1.4.2.md)
         - [Version 1.4.1](changelogs/1.4.x/1.4.1.md)
         - [Version 1.4.0](changelogs/1.4.x/1.4.0.md)
-
     - [1.3.x]()
         - [Version 1.3.0](changelogs/1.3.x/1.3.0.md)
-
     - [1.2.x]()
         - [Version 1.2.0](changelogs/1.2.x/1.2.0.md)
-
     - [1.1.x]()
         - [Version 1.1.1](changelogs/1.1.x/1.1.1.md)
         - [Version 1.1.0](changelogs/1.1.x/1.1.0.md)
-
     - [1.0.x]()
         - [Version 1.0.0](changelogs/1.0.x/1.0.0.md)
-
     - [Pre-1.0.x]()
         - [Version 0.9.0](changelogs/0.9.x/0.9.0.md)
+- [Team Procedures]()
+    - [How to make an Expansion version](team_procedures/expansion_versions.md)
diff --git a/docs/changelogs/1.9.x/1.9.3.md b/docs/changelogs/1.9.x/1.9.3.md
@@ -0,0 +1,106 @@
+# Version 1.9.3
+
+```md
+## How to update
+- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
+- Once you have your remote set up, run the command `git pull RHH expansion/1.9.3`.
+```
+
+## 🌋 *REFACTORS* 🌋
+📜 = Uses a migration script.
+* Converted `settotemboost` command to `callnative` in [#5418](https://github.com/rh-hideout/pokeemerald-expansion/pull/5418)
+* Removed unused `RESOURCE_FLAG_TRACED` in [#5430](https://github.com/rh-hideout/pokeemerald-expansion/pull/5430)
+* Changed `MOVEEND_` defines to an enum in [#5449](https://github.com/rh-hideout/pokeemerald-expansion/pull/5449)
+
+## ✨ Feature Branches ✨
+### ***merrp/aarant's Followers***
+#### Fixed
+* Fixed Expansion-exclusive issue that caused trainers to not play their "pointing" animation when Followers were out during battle intro by @kittenchilly in [#5406](https://github.com/rh-hideout/pokeemerald-expansion/pull/5406)
+
+## ⚔️ Battle General ⚔️ ##
+### Changed
+* Improved Mega evolution animation to make it a little smoother by @kleenxfeu in [#4816](https://github.com/rh-hideout/pokeemerald-expansion/pull/4816)
+### Fixed
+* Fixed affection check for exp multiplier by @Bassoonian in [#5421](https://github.com/rh-hideout/pokeemerald-expansion/pull/5421)
+* Fixed multiple Primal Reversions not occurring if multiple battlers fainted on the previous turn by @PhallenTree in [#5430](https://github.com/rh-hideout/pokeemerald-expansion/pull/5430)
+
+## 🤹 Moves 🤹
+### Added
+* Added missing `B_AFTER_YOU_TURN_ORDER` config by @PhallenTree in [#5400](https://github.com/rh-hideout/pokeemerald-expansion/pull/5400)
+    * Gen 5-7: After You fails if the order remains the same after using After You.
+    * Gen 8+: After You no longer fails if the turn order remains the same after using After You.
+* Added missing `B_QUASH_TURN_ORDER` config by @PhallenTree in [#5400](https://github.com/rh-hideout/pokeemerald-expansion/pull/5400)
+    * Gen 5-7: If multiple Pokémon are affected by Quash, they move in the order they were affected by Quash.
+    * Gen 8+: If multiple Pokémon are affected by Quash, they now move fastest to slowest.
+* Added missing updated `B_UPDATED_CONVERSION_2` by @wiz1989 in [#5453](https://github.com/rh-hideout/pokeemerald-expansion/pull/5453)
+    * Gens 2-4: Conversion 2 changes the user's type to a type that is resistant/immune to the last move the user was hit by.
+    * Gen 5+: Conversion 2 changes the user's type to a type that resists the last move used by the selected target.
+### Fixed
+* Fixed Scale Shot corrupting the move used on the next turn by @AlexOn1ine in [#5397](https://github.com/rh-hideout/pokeemerald-expansion/pull/5397)
+* Fixed Growth's description not being updated based on `B_GROWTH_STAT_RAISE` by @nescioquid in [#5398](https://github.com/rh-hideout/pokeemerald-expansion/pull/5398)
+* Fixed Quash not updating the battlers' actions correctly by @PhallenTree in [#5400](https://github.com/rh-hideout/pokeemerald-expansion/pull/5400)
+    * Cleanup by @PhallenTree in [#5430](https://github.com/rh-hideout/pokeemerald-expansion/pull/5430)
+* Fixed Snatched Swallow not recovering HP if the Snatcher is not under the effect of Stockpile (should still heal) by @PhallenTree in [#5430](https://github.com/rh-hideout/pokeemerald-expansion/pull/5430)
+* Fixed Counter users being damaged by Spiky Shield by @AlexOn1ine in [#5402](https://github.com/rh-hideout/pokeemerald-expansion/pull/5402)
+* Fixed Electrified Dragon Darts not correctly avoiding targets with ability immunity (Volt Absorb, Motor Drive) by @PhallenTree in [#5430](https://github.com/rh-hideout/pokeemerald-expansion/pull/5430)
+* Fixed Trace not activating a switch-in ability it traces (eg. Intimidate) by @PhallenTree in [#5430](https://github.com/rh-hideout/pokeemerald-expansion/pull/5430)
+    * Removed unused `RESOURCE_FLAG_TRACED`.
+* Fixed recoil damage not triggering healing berries by @AlexOn1ine in [#5449](https://github.com/rh-hideout/pokeemerald-expansion/pull/5449)
+    * Also changed `MOVEEND_` defines to an enum.
+## 🎭 Abilities 🎭
+### Fixed
+* Fixed Dancer activating even if the dance move is stolen by Snatch by @PhallenTree in [#5430](https://github.com/rh-hideout/pokeemerald-expansion/pull/5430)
+* Fixed Ability popup when multiple Pokémon faint at the same time by @PhallenTree in [#5430](https://github.com/rh-hideout/pokeemerald-expansion/pull/5430)
+* Multiple ability fixes by @PhallenTree in [#5447](https://github.com/rh-hideout/pokeemerald-expansion/pull/5447)
+    * Fixed Protosynthesis/Quark Drive sometimes not activating ability popup despite still gaining the boost as they should.
+    * Fixed Protosynthesis/Quark Drive activating on Transformed battlers.
+    * Fixed Protosynthesis activating despite Cloud Nine being present on the field.
+    * Fixed Quark Drive not activating if the battler is not grounded.
+    * Fixed Protosynthesis/Quark Drive/Beast Boost stat raise priority when multiple stats are tied for the highest one.
+        * Before: `Attack, Defense, Speed, Special Attack, Special Defense`.
+        * After: `Attack, Defense, Special Attack, Special Defense, Speed`.
+
+## 🧶 Items 🧶
+### Fixed
+* Fixed Ogerpon's Masks not increasing the power of moves by 20% by @AlexOn1ine in [#5391](https://github.com/rh-hideout/pokeemerald-expansion/pull/5391)
+* Fixed Jubilife Muffin not working by @kittenchilly in [#5444](https://github.com/rh-hideout/pokeemerald-expansion/pull/5444)
+* Fixed duplicating flute bug in double battles by @ghoulslash in [#5436](https://github.com/rh-hideout/pokeemerald-expansion/pull/5436)
+
+## 🤖 Battle AI 🤖
+### Fixed
+* Fixed Trick/Switcheroo giving AI score even if the opponent has no held item by @kittenchilly in [#5412](https://github.com/rh-hideout/pokeemerald-expansion/pull/5412)
+* Various AI fixes in `AI_CalcMoveEffectScore` by @ghoulslash in [#5474](https://github.com/rh-hideout/pokeemerald-expansion/pull/5474)
+    * Missing break from `EFFECT_ABSORB` switch case.
+    * Using last used move for Mirror Move instead of predicted move.
+
+## 🧹 Other Cleanup 🧹
+### Changed
+* Converted `settotemboost` command to `callnative` by @ghoulslash in [#5418](https://github.com/rh-hideout/pokeemerald-expansion/pull/5418)
+* Removed trailing whitespace by @kittenchilly in [#5455](https://github.com/rh-hideout/pokeemerald-expansion/pull/5455)
+* Removed binary match workaround for Rayquaza's tail in Sootopolis' cutscene by @hedara90 in https://github.com/rh-hideout/pokeemerald-expansion/pull/5480
+### Fixed
+* Fixed potential uninitialized behavior in `ChangeOrderTargetAfterAttacker` by @AlexOn1ine in [#5393](https://github.com/rh-hideout/pokeemerald-expansion/pull/5393)
+* Fallback on default BW map pop-up theme to reduce potential for error by @ravepossum in [#5392](https://github.com/rh-hideout/pokeemerald-expansion/pull/5392)
+* Multiple typo fixes by @nescioquid in [#5398](https://github.com/rh-hideout/pokeemerald-expansion/pull/5398)
+* VS Seeker documentation fix by @Bassoonian in [#5415](https://github.com/rh-hideout/pokeemerald-expansion/pull/5415)
+
+## 🧪 Test Runner 🧪
+### Added
+* Added missing After You and Quash tests by @PhallenTree in [#5400](https://github.com/rh-hideout/pokeemerald-expansion/pull/5400)
+### Changed
+* Improved Tangling Hair test to make sure that chained effects do not overwrite relevant battler IDs by @ghoulslash in [#5423](https://github.com/rh-hideout/pokeemerald-expansion/pull/5423)
+* Improved Full Heal item tests by @kittenchilly in [#5444](https://github.com/rh-hideout/pokeemerald-expansion/pull/5444)
+### Fixed
+* Fixed Wake-Up Slap test typo by @Pawkkie in [#5442](https://github.com/rh-hideout/pokeemerald-expansion/pull/5442)
+* Fixed test assumption fail summary fields using more memory than needed by @AsparagusEduardo in [#5443](https://github.com/rh-hideout/pokeemerald-expansion/pull/5443)
+* Fixed issue with `PASSES_RANDOMLY` in AI tests by @Pawkkie in https://github.com/rh-hideout/pokeemerald-expansion/pull/5486
+
+## New Contributors
+* @nescioquid made their first contribution in [#5398](https://github.com/rh-hideout/pokeemerald-expansion/pull/5398)
+* @kleenxfeu made their first contribution in [#4816](https://github.com/rh-hideout/pokeemerald-expansion/pull/4816)
+* @wiz1989 made their first contribution in [#5453](https://github.com/rh-hideout/pokeemerald-expansion/pull/5453)
+
+**Full Changelog**: https://github.com/rh-hideout/pokeemerald-expansion/compare/expansion/1.9.2...expansion/1.9.3
+
+<!--Last PR: 5486-->
+<!--Used to keep track of the last PR merged in case new ones come in before the changelog is done.-->