Releases: rh-hideout/pokeemerald-expansion
Releases · rh-hideout/pokeemerald-expansion
pokeemerald-expansion 1.0.0 (2022-09-09)
To merge in this update, use the command git pull expansion-1.0.0
after setting up this repo as a remote
BREAKING
- Reworked TMHM into expandable list format by @gruxor in #2233
- Tutor moves and TM/HM moves have been combined into a single list of Teachable Moves.
- With this change, it allows users to have official data for compatibility if they add their own TMs/HMs and Tutors.
- Added Legends: Arceus species by @Blackforest92 in #2177
- Fixed PokemonSubstruct3 alignment by @AsparagusEduardo in #2265
ADDED
- Added Legends: Arceus' move data by @LOuroboros in #2280
- Inclusion of the TheXaman's Debug Menu by @TheXaman in #2277
- Introduced FORM_BATTLE form changes by @LOuroboros in #2273
- Form changes for Zacian, Zamazenta and Xerneas before a battle's intro.
- Optional parameter to check for held item.
- Introduced
param3
to facilitate this and merging of FORM_ITEM_USE.
- Introduced
CHANGED
- Merged FORM_ITEM_USE_TIME into FORM_ITEM_USE by @LOuroboros in #2304
- Comatose prevents Battle Pike's status effects. by @AsparagusEduardo in #2198
- Updated Serene Grace checks in AI_CheckViability by @LOuroboros in #2218
FIXES
- Fixed Quash's effect by @DizzyEggg in #2239
- Fixed pickup running when it shouldn't in some cases. by @StephenLynx in #2284
- Dragon Tail Weak Armor fix by @DizzyEggg in #2278
- Fix Magic Bounce targets by @DizzyEggg in #2260
- Fixed ball multiplier fallthroughs by @AsparagusEduardo in #2290
- Weather forms fixes and config by @Sneed69 in #2150
- Fixed compile error when using
GEN_3
setting for sport moves by @Yak-Attack-1012 in #2295
PRET MERGES
- Up to 578064d (2022-08-26) by @AsparagusEduardo in #2286
CLEANUP
- Updated README.md to reflect the new workflow by @LOuroboros in #2287
- Updated README.md with credits and wiki links by @ghoulslash in #2299
- Config refactor by @AsparagusEduardo in #2297
- Refactored uses of configs to be exclusivetly handled by preproc, as an optimization such that we don't have stuff like (is 3 > 4?)
- Moved Gen definitions to
include/config.h
, to be used by all config files. - Created
GEN_LATEST
as a way to avoid conflicts with users that modify the default configs and have a way for them to easily set everything to their prefered generation.
- Tyding graphics
- Tidying Graphics/Battle_Anims by @Blackforest92 in #2289
- Acupressure by @Blackforest92 in #2301
- Small syntax fix for CanLearnTeachableMove by @LOuroboros in #2302
- Added missing constant in GetBattleMonMoveSlot by @LOuroboros in #2294
New Contributors
- @StephenLynx made their first contribution in #2284
- @Yak-Attack-1012 made their first contribution in #2295
Full Changelog: expansion/0.9.0...expansion/1.0.0
pokeemerald-expansion 0.9.0 (2022-08-29)
To merge in this update, use the command git merge expansion-0.9.0
after setting up this repo as a remote.
This version was labeled retroactively after our versioning scheme was decided, meaning the version number may be arbitrary.
ADDED
- Support for double wild battles with a single opponent by @DizzyEggg in #2238
- Gen 8 EXP Candies by @AgustinGDLV in #2142
- Affection/friendship battle mechanics by @LOuroboros in #2173
CHANGED
- Moves with EFFECT_PLACEHOLDER can't be used anymore. by @AsparagusEduardo in #2243
- Modified HP display to support HP with 4 digits by @DizzyEggg in #2256
- Enable BUGFIX by default by @AsparagusEduardo in #2258
- Updated Fairy icon to better match the rest of them by @AsparagusEduardo in #2269
FIXES
- Gen5+ multihit odds. by @aarant in #2219
- IsAbilityPreventingEscape message in party menu by @ghoulslash in #2125
- ENDTURN_WISH not resetting gBattleStruct->turnSideTracker by @DizzyEggg in #2236
- Ability pop-up not displaying long abilities properly by @DizzyEggg in #2234
- Doubles 2 vs 1 interface by @DizzyEggg in #2238
- Fixed creation trio orbs not boosting power for non-base forms. by @AsparagusEduardo in #2242
- LoadSpecialPokePic now loads gender differences correctly by @AsparagusEduardo in #2247
- Fixed Net Ball Gen 7+ multiplier by @AsparagusEduardo in #2259
- Fix Escape Rope Message when on gen 8 mechanics by @ThirdLemon in #2263
PRET MERGES
- Up to 578064d by @AsparagusEduardo in #2264
CLEANUP
- Fix multiple pokemon icons & tidying pokemon graphic folders by @Blackforest92 in #2206
- Get rid of garbage bytes in graphics.c by @DizzyEggg in #2235
- Fixed P_UPDATED_ABILITIES's comment by @LOuroboros in #2241
- Fixed critical capture fields not using TRUE or FALSE by @AsparagusEduardo in #2245
- Reworked branch defines into single compatibility define by @gruxor in #2237
- Removed unused local var in SetMonFormPSS by @LOuroboros in #2271
New Contributors
- @ThirdLemon made their first contribution in #2263
Full Changelog: expansion/0.8.0...expansion/0.9.0
Version 1.8.0
## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.8.0`.
🌋 IMPORTANT CHANGES 🌋
-
Python is now a required for the Expansion.
- Run the
command -v python3
command to see if you have it. If you don't, please check INSTALL.md to see how to install it.
- Run the
-
Support for PoryMap v5.1.1 and lower has been dropped.
- Please update your PoryMap version.
- Specifically, we have removed the commented-out
gMonIconTable
table used to associate species IDs with icon images by @Bassoonian in #3896- From PoryMap v5.2.0 onwards, these icons are autodetected based on file/directory names instead.
- To continue using older versions of PoryMap, you may restore the commented-out table, though you'll need to keep it up to date with any new items you add.
-
Backwards-compatible
BoxPokemon
Refactor by @mrgriffin in #3438- HP and Status is now kept when depositing Pokémon in the PC
- Previous behavior can be restored by setting
OW_PC_HEAL
.
- Previous behavior can be restored by setting
- Nature Mints are now fully functional.
- Nature colors in summary screen are based on the changed nature by @Bassoonian in #3898
- Gigantamax Factor and Dynamax Level fully supported.
- Cannot be seen in summary screen.
- Dynamax Candy effect added.
- Gigantamax Factor prevents Duraludon from evolving, like Pikachu, Eevee and Meowth beforehand.
- Added
hasgigantamaxfactor
andtogglegigantamaxfactor
overworld script commands.- Gigantamax Factor cannot be toggled for Mythical Pokémon (vanilla behavior).
- Hyper Training is now fully supported.
- Cannot be seen in summary screen.
- Added
canhypertrain
andhypertrain
overworld script commands.
- Shininess can be toggled with
MON_DATA_IS_SHINY
. - Added Tera Type field is added for future-proofing.
- It can be seen in the summary screen by turning
P_SHOW_TERA_TYPE
on.
- It can be seen in the summary screen by turning
- Added
isShadow
field for future-proofing. - Added options for Tera Type, Dynamax Level, Gigantamax Factor and Shadow flag in tests.
- Cleanup by
- HP and Status is now kept when depositing Pokémon in the PC
-
Move Refactors:
- Move data unification by @LOuroboros, with help from @Bassoonian, @cfmnephrite and @AsparagusEduardo in #3999
- Renamed
gBattleMoves
togMovesInfo
. - Moved move names to
gMovesInfo
.- Added
GetMoveName
to get all move names, removing the need forGetMaxMoveName
andGetZMoveName
.
- Added
- Moved move descriptions to
gMovesInfo
. - Moved contest data to
gMovesInfo
.
- Renamed
- Secondary/primary effects overhaul by @cfmnephrite in #3577
- Secondary effects such as stat stage modifiers and status via are now set via
additionalEffects
field. - Eg.
Now becomes:
[MOVE_THUNDER_FANG] = { .effect = EFFECT_FLINCH_STATUS, .secondaryEffectChance = 10, .argument = STATUS1_PARALYSIS, ... },
With customizable independent chances for each effect. Because of this,[MOVE_THUNDER_FANG] = { .effect = EFFECT_HIT, .additionalEffects = ADDITIONAL_EFFECTS( { .moveEffect = MOVE_EFFECT_PARALYSIS, .chance = 10, }, { .moveEffect = MOVE_EFFECT_FLINCH, .chance = 10, } ), ... },
secondaryEffectChance
has been removed. - For more info, check the wiki article on How to add a new move.
- Cleanup by:
- @GraionDilach in #3986
- @AlexOn1ine in #4003
- By @cfmnephrite in #4137
- By @AlexOn1ine in #4277
- Secondary effects such as stat stage modifiers and status via are now set via
- Renamed Battle Move "Split" to the proper "Category" term by @AsparagusEduardo in #3774
-.split = SPLIT_PHYSICAL, +.category = DAMAGE_CATEGORY_PHYSICAL,
- Z-move power override (eg. Mega Drain) was moved from a switch in
GetZMovePower
to move data. It's part of an union alongsize with Z-move status effect by @cfmnephrite in #3575- Cleanup by @AsparagusEduardo in #4201
- Removed
EFFECT_RECOIL_x
effects in favor of newrecoil
field by @cfmnephrite in #3575 - Removed critical-hit move effects in favor of new
criticalHitStage
by @cfmnephrite in #3779- Added
alwaysCriticalHit
move flag.
- Added
- Converted
EFFECT_x
defines to an enum by @cfmnephrite in #3975 - Move data now uses ternaries for data that was changed only once across generations by @AsparagusEduardo in #3987
[MOVE_SWORDS_DANCE] = { - #if B_UPDATED_MOVE_DATA >= GEN_6 - .pp = 20, - #else - .pp = 30, - #endif .effect = EFFECT_ATTACK_UP_2, .power = 0, .type = TYPE_NORMAL, .accuracy = 0, + .pp = B_UPDATED_MOVE_DATA >= GEN_6 ? 20 : 30,
- Moved effect script array to
src/data/battle_move_effects.h
by @cfmnephrite in #3994- AI's
sEncouragedEncoreEffects
and Battle TV'ssPoints_MoveEffect
are now handled in this struct. - Some move flags were moved to this array instead
- Semi-invulnerable flag (
semiInvulnerableEffect
) in #4062- Cleanup by @cfmnephrite in #4150
- Flag to define Two-turn effects (
twoTurnEffect
) in #4062 - Flag for increasing the protection counter (
usesProtectCounter
) in #4062
- Semi-invulnerable flag (
- AI's
- Removed
sheerForceBoost
in favor of checking their actual secondary effects by @cfmnephrite in #4096- To force Sheer Boost acting for a move without secondary effect, you can add
SHEER_FORCE_HACK
in theadditionalEffects
field.
- To force Sheer Boost acting for a move without secondary effect, you can add
- Move data unification by @LOuroboros, with help from @Bassoonian, @cfmnephrite and @AsparagusEduardo in #3999
-
Learnset refactors
- Level up learnsets can now be switched by generational config by @MartyKen in #4049
- Adds a file for each generation with data for all species.
- Gen 1: Yellow
- Gen 2: Crystal
- Gen 3: RSE
- Gen 4: HGSS
- Gen 5: B2W2
- Gen 6: ORAS
- Gen 7: USUM
- Gen 8:
- Species from Gens 1-4: BDSP
- Species from Legends: Arceus: Use that game's data.
- Species from Gens 5-8: SwSh if they exist there. Otherwise, default to Gen 7's data.
- Gen 9:
- If they exist in SV, use that game's data.
- Otherwise, default to Gen 8's data.
- If a Pokémon doesn't exist in the respective generation, it uses the first instance it appears in.
- Eg. Chikorita uses its Gen 2 learnset if the config is set to Gen 1.
- IMPORTANT: Since the expansion's default had most movesets correspond to USUM's, conflicts will arise in
data/pokemon/level_up_learnsets/gen_7.h
if you modified the level learnsets. Be sure to backup yourdata/pokemon/level_up_learnsets.h
before merging and then do the following after merging to keep your changes:+#include "data/pokemon/level_up_learnsets.h" +#if FALSE + #if P_LVL_UP_LEARNSETS >= GEN_9 #include "data/pokemon/level_up_learnsets/gen_9.h" #elif P_LVL_UP_LEARNSETS >= GEN_8 #include "data/pokemon/level_up_learnsets/gen_8.h" #elif P_LVL_UP_LEARNSETS >= GEN_7 #include "data/pokemon/level_up_learnsets/gen_7.h" #elif P_LVL_UP_LEARNSETS >= GEN_6 #include "data/pokemon/level_up_learnsets/gen_6.h" #elif P_LVL_UP_LEARNSETS >= GEN_5 #include "data/pokemon/level_up_learnsets/gen_5.h" #elif P_LVL_UP_LEARNSETS >= GEN_4 #include "data/pokemon/level_up_learnsets/gen_4.h" #elif P_LVL_UP_LEARNSETS >= GEN_3 #include "data/po...
- Adds a file for each generation with data for all species.
- Level up learnsets can now be switched by generational config by @MartyKen in #4049
Version 1.7.4
## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.Y.Z`.
🧬 General 🧬
Fixed
- HGSS Dex fixes:
- Fixed inconsistent list tileset between capped and decapped modes by @ravepossum in #4126
- Fixed screen select bar popping in too early for area screen by @ravepossum in #4094
- Fixed Lotad/Seedot house using species weight instead of height by @Bassoonian in #4195
🐉 Pokémon 🐉
Fixed
- Fixed Ogerpon shiny palettes by @AsparagusEduardo in #4165
- Fixed Basculegion back sprite offset by @MelonSpeedruns in #4198
- Fixed Greninja form animations by @MelonSpeedruns in #4198
- Fixed compile error when
P_GEN_8_CROSS_EVOS
is enabled but notP_GEN_9_CROSS_EVOS
due to Ursaluna's cry being labled as Gen 9 by @AsparagusEduardo in #4210 - Fixed Curly Tatsugiri and Green Plumage Squawkabilly icons not showing up properly in later versions of Porymap by @kittenchilly in #4212
⚔️ Battle General ⚔️
Fixed
- Fixed disobedience not resetting multihit moves by @DizzyEggg in #4133
- Fixed switch in interactions with hold effects abilities by @AlexOn1ine in #4091
- Download activating on an empty field.
- Intimidate activating on an empty field and not activating upon new opponent switching in.
- Primal Reversion not happening immediately upon switching in from U-turn.
- Held items not being triggered when switching in fron U-turn and Intimidate being triggered beforehand.
- Fixed LastUsedBall issues not being saved and DisplayBall not being shown by @Wesmaster in #4209
🤹 Moves 🤹
Fixed
- Fixed move animations crashing on some emulators because of division by zero by @DizzyEggg in #4121
- Flip Turn, Anchor Shot, Snipe Shot and Incinerate were affected by this.
- Fixed Eerie Spell consuming double PP and showing its message twice by @AlexOn1ine in #4127
- Fixed Fairy Lock animation by @DizzyEggg in #4111
🎭 Abilities 🎭
Added
- Added Gen 5+ config for Soundproof no longer preventing Uproar status by @AlexOn1ine in #4174
Fixed
- Fixed Mycelium Might speed calculation by @AlexOn1ine in #4146
- Fixed Stench triggering on non-damaging attacks by @HungryPickle in #4159
- Fixed Disguise not ending the battle in the correct form by @AsparagusEduardo in #4167
- Fixed Opportunist accumulating stat changes by @AlexOn1ine in #4168
🧶 Items 🧶
Fixed
- Kee Berry fixes by @AlexOn1ine in #4149
- Fixed triggering if the holder does a physical attack instead of receiving it.
- Fixed it boosting the target's defense if the attacker holds a Kee Berry, while still displaying the boost animation for the holder.
- Fixed poison-healing items not reseting Toxic Counter by @DizzyEggg in #4135
🧹 Other Cleanup 🧹
Changed
- Clean up space/tabs difference by @Bassoonian in #4163
- Deleted a space by @cmy2008 in #4194
New Contributors
- @cmy2008 made their first contribution in #4194
- @MelonSpeedruns made their first contribution in #4198
Full Changelog: expansion/1.7.3...expansion/1.7.4
Version 1.7.3
## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.7.3`.
🌋 IMPORTANT CHANGES 🌋
- Unused warnings are no longer treated as errrors by default by @AsparagusEduardo in #4092
- [Critical fix] Backported gHeap alignment fix from upstream pret by @SBird1337 and @AsparagusEduardo in #4089
- Fixes issue that causes graphics to bug when leaving Littleroot for Birch's cutscene.
🧬 General 🧬
- Fixed HGSS Dex's dark mode search palette by @ravepossum in #4095
🐉 Pokémon 🐉
Changed
- Condensed Oinkologne teachable learnsets (they previously had different tables despite having the same learnsets) by @Bassoonian in #4026
- Removed illegal teachable learnset moves that didn't match Gen 7 or 9 by @Bassoonian in #4039 and #4042
Fixed
- Fixed incorrect family toggle preproc blocks by @AsparagusEduardo in #4024
- Cosplay and Cap Pikachu animations were still being included even if disabled.
- Fixed compile errors when:
- Feebas' family was disabled but not Castform.
- Chatot was disabled but not Spiritomb.
- Virizion was disabled but not Tornadus or Thundurus.
- Zekrom was disabled but not Landorus.
- Kyurem was disabled but not Keldeo or Meloetta.
- Wishiwashi was disabled but not Rockruff.
- Fixed compile error when disabling Gen 4 cross-evolutions while having Kingdra enabled by @Skyeward and @Bassoonian in #4044 and #4046
⚔️ Battle General ⚔️
Fixed
- Fixed Steven double battle palette error by @johannakullmann in #4078
🤹 Moves 🤹
Changed
- Renamed
EFFECT_STEEL_BEAM
toEFFECT_MAX_HP_50_RECOIL
by @AlexOn1ine in #4043
Fixed
- Fixed Pursuit's effect not working by @ZnogyroP @AlexOn1ine in #4086
🎭 Abilities 🎭
Fixed
- Fixed Emergency Exit issues:
- Fixed rounding error that caused it to not switch out when odd-numbered HP was off by 1 by @SBird1337 in #4040
- Eg: going from 101 Max HP to 50 HP would've not cause it to switch out.
- Fixes Emergency Exit switching out even if the Pokémon was healed above the threshold before it would've triggered by @AlexOn1ine in #4041
- Eg: going from 100 Max HP to 45 HP and eating a Sitrus Berry back to 55 HP would've cause it to switch out.
- Cleanup by @AlexOn1ine in #4100
- Fixed rounding error that caused it to not switch out when odd-numbered HP was off by 1 by @SBird1337 in #4040
- Fixed Corrosion only working for status moves by @AlexOn1ine in #4037
- Fixed Magic Guard not preventing Mind Blown recoil damage by @AlexOn1ine in #4043
🧶 Items 🧶
Fixed
- Fixed oversight causing chosen fossil to be lost if bag is full by @fakuzatsu in #3978
- Fixed other Key Item script oversights by @Bassoonian in #4066
- Fixed Life Orb causing damage on switch-in from Eject Pack and Red Card by @AlexOn1ine in #4038
- Fixed Glimmering Charm sprite by @SonikkuA-DatH and @AlexOn1ine in #4047
🤖 Battle AI 🤖
Fixed
- Fixed AI trying to switch into the same mon twice in the same turn by @DizzyEggg in #4098
🧪 Test Runner 🧪
Added
- Corrosion tests by @AlexOn1ine in #4037
- Pursuit/Tangling Hair interaction by @ZnogyroP @AlexOn1ine in #4086
Changed
- Passing
KNOWN_FAILING
tests are now listed separately fromPASSED
tests by @AsparagusEduardo in #4063
New Contributors
Full Changelog: expansion/1.7.2...expansion/1.7.3
Version 1.7.2
## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.7.2`.
🧬 General 🧬
Changed
- Pokédex Ratings now dynamically adapt to the size of the regional dex, instead of being harcoded at set intervals of 10 up to 200 by @Bassoonian in #3900
- Mythical Pokémon are skipped from the rating unless they have the
dexForceRequired
flag by @Bassoonian in #3937
- Mythical Pokémon are skipped from the rating unless they have the
- Updates to INSTALL.MD for 1.7.0+ and misc clarifications by @ravepossum in #3983
Fixed
- Fixed HGSS Pokédex showing incorrect preevolutions by @kaisermg5 in #3894
- Fixed typo in HGSS Pokédex by @Ninjdai1 in #3958
- Fixed Hall of Fame not showing proper 4-digit dex numbers by @Bassoonian in #3901
- Fixed debug menu flags not redrawing correctly by @ravepossum in #3916
- Fixed issue when trying to add new party menu field moves by @johannakullmann in #3933
- Fixed RHH Rom Header shifting addresses by @Ninjdai1 in #3980
🐉 Pokémon 🐉
Added
- Added missing form dex entries by @AsparagusEduardo in #3972
- Meloetta Pirouette
- Mega Diancie
- Hoopa Unbound
- Gigantamax Sandaconda
Changed
- Multiple Pokémon graphical improvements by @katykat5099 in #3805
- Improved Tyrantrum's back sprite.
- Improved Zigzagoon and Linoone's palette
- Updated Gen 9 Pokémon icons to @CyanSMP64's improvements
- Annihilape
- Arctibax and Baxcalibur
- Bellibolt
- Bramblin and Brambleghast
- Cetoddle and Cetitan
- Charcadet, Armarouge and Ceruledge.
- Chi-Yu and Chien-Pao
- Clodsire
- Crocalor
- Dolliv
- Dudunsparce
- Esparthra
Fixed
- Multiple Pokémon graphical fixes by @katykat5099 in #3805
- Fixed Togepi having a missing pixel on its icon's first frame.
- Fixed Litwick having a missing pixel on its front sprite.
- Fixed Krookodile having a stray pixel on its front sprite.
- Fixed Duraludon's palette.
- Fixed Egg graphical data not being properly read by @AsparagusEduardo in #3879
- Fixed Dugtrio's missing footprint and forms not appearing in the HGSS dex by @kaisermg5 in #3897
- Fixed Paldean Tauros having the base stats of Kantonian Tauros by @AlexOn1ine in #3970
- Fixed Hisuian Electrode having the wrong evolution method (evolving "at level 214" instead of via Leaf Stone) by @AlexOn1ine in #3970
⚔️ Battle General ⚔️
Changed
- Re-enabled Z-Move Usage in Battle Frontier by @damon-murdoch in #3883
Fixed
- Fixed weird stat drop animation by @DizzyEggg in #3870
- Fixed Battle Frontier Multi Battles randomly ending in loss by @Bassoonian in #3990
🤹 Moves 🤹
Fixed
- Fixed Bleakwind Storm, Wildbolt Storm and Sandsear Storm not targetting both foes and not skipping accuracy check under rain by @damon-murdoch in #3884
- Updated move animations to account for this target change by @ghoulslash in #3895
- Fixed Inner Focus breaking when
B_WAIT_TIME_MULTIPLIER
config was being set to any value other than 16. - Fixed Collision Course's and Electro Drift's PP being 10 instead of 5 by @fdeblasio in #3890
- Fixed "Sea of Fire" Pledge effect damaging fainted PokémonSome pledge combo fixes by @ghoulslash in #3934
- Fixed Syrup Bomb's effect not being cleared when the user leaves the field by @AlexOn1ine in #3948
- Fixed Dragon Darts hitting 3 times instead of 2 (full effect still not done) by @AlexOn1ine in #4014
🧶 Items 🧶
Fixed
- Fixed Unremarkable Teacup, Masterpiece Teacup and Syrupy Apple's effects by @kittenchilly in #3858
- Fixed Poké Balls getting 100% catch rate by @AlexOn1ine in #3955
- Fixed item usage in double battles by @AlexOn1ine in #3977
🤖 Battle AI 🤖
Fixed
- Fixed small AI bulldoze effect bug by @AlexOn1ine in #3872
🧹 Other Cleanup 🧹
Fixed
- Fixed Quick/Wide Guard config comments by @Bassoonian in #3857
🧪 Test Runner 🧪
Added
- Added missing Strength Sap tests by @DizzyEggg in #3860
- Added Clanging Scales test by @AlexOn1ine in #3973
- Added 5 Parental Bond tests by @AlexOn1ine in #3973
Changed
- Consistent
BENCHMARK
timing by @mrgriffin in #3867
New Contributors
- @damon-murdoch made their first contribution in #3883
- @lordraindance2 made their first contribution in #3885
- @johannakullmann made their first contribution in #3933
Full Changelog: expansion/1.7.1...expansion/1.7.2
Version 1.7.1
2023-12-28
## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.7.1`.
🧬 General 🧬
Changed
- Deprecate agbcc and clarify gcc version usage in install instructions. by @GraionDilach in #3788
Fixed
- Fix Update Message Saying 1.6.2 by @kaicardenas2 in #3759
- Fix exp gain when defeating two opponents at once by @ghoulslash in #3798
- Fix debug menu toggling first flag by @DizzyEggg in #3796
🐉 Pokémon 🐉
Fixed
- Fix Maushold-3 and Maushold-4 icons being swapped by @kittenchilly in #3809
- Fixes Minior form change and likely other forms by @AlexOn1ine in #3822
- Fix P_FAMILY #if blocks for Regigigas and Giratina in front_pic_anims.h by @gabrielcowley in #3823
🤹 Moves 🤹
Added
- Adds data for The Indigo Disk moves by @Bassoonian in #3852
- Many moves still have placeholder effects.
Fixed
- Fix Telekinesis not working by @DizzyEggg in #3763
- Fix Ion Deluge interaction with Volt Absorb andLightning Rod by @DizzyEggg in #3764
- Fix Max Moves animations by @GraionDilach in #3769
- Fix Cotton Down overwriting gBattlerAttacker by @ghoulslash in #3783
- Fix Photon Geyser by @AlexOn1ine in #3803 and #3807
- Fix Metronome crash by @Bassoonian in #3852
🎭 Abilities 🎭
Fixed
- Fix Ice Face ignoring move effects by @DizzyEggg in #3755
- Fix Frisk ability pop-up showing wrong battler by @DizzyEggg in #3762
- Prankster tests + fixes by @DizzyEggg in #3766
🧶 Items 🧶
Fixed
- Fixes Item Metronome damage by @AlexOn1ine in #3767
- Fix gem boost description + test by @Bassoonian in #3817
🧹 Cleanup 🧹
- Clear BattleScripting struct at the battle start by @DizzyEggg in #3776
- Fix Rain Dance and Sunny Day not blending opponent sprite by @DizzyEggg in #3785
- Same lists for healing moves by @DizzyEggg in #3787
- [battle_controller_player.c] refactor and fix buffer overread by @SBird1337 in #3792
- Make overworld weather-based terrain setting effects use B_MSG_TERRAIN_SET constants for intro text by @ravepossum in #3793
- Clear Sky Battle & Dynamax flags upon whiteout by @Bassoonian in #3830
🧪 Test Runner 🧪
Added
- Small test runner improvements by @mrgriffin in #3761
- EXPECT_MUL_EQ thresholds are always at least ±1 by @kittenchilly in #3768
- Added last CannotUseItemsInBattle tests by @LOuroboros in #3789
New Contributors
- @kaicardenas2 made their first contribution in #3759
Full Changelog: expansion/1.7.0...expansion/1.7.1
Version 1.7.0
2023-12-17
## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.7.0`.
🌋 IMPORTANT CHANGES 🌋
The Expansion now uses Modern compilers by default
- We have enabled
-Werror -Wall
in the Makefile. These flags show warnings for undefined behaviors in the old compiler (agbcc
), and sets all warnings as errors. As such, we have updated the codebase so that all warnings that gcc 13 throws are handled:- CI now uses devkitarm container to run a more modern gcc by @SBird1337 in #3429
- Fix by @AsparagusEduardo in #3530
- Fixed
-Wall -Werror
errors on Modern by @DizzyEggg in #3412 - Fixed warnings introduced by gcc 13 by @SBird1337 in #3428
-Warray-bounds
-Waddress
-Warray-parameter
- Fixed
-Wmaybe-uninitialized
forModifyPersonalityForNature
test by @SBird1337 in #3457
- CI now uses devkitarm container to run a more modern gcc by @SBird1337 in #3429
- Modern compiler may raise the following errors for code introduced from outside the expansion, so we recommend solving those errors:
unused-function
. To solve it, addUNUSED
to the function definition.-static void Function(void) +static void UNUSED Function(void)
unused-variable
. To solve it, remove the unused variable.static void Function(void) { - u8 unused; u8 used; ...
unused-but-set-variable
. To solve it, addUNUSED
to the variable definition.static void Function(void) { - u8 unused; + u8 UNUSED unused; u8 used; unused = DoSomething(); ...
- Updated modern compiler install instructions by @hedara90 in #3527
- You may still use
agbcc
by addingagbcc
to yourmake
command to finish the update process before fixing these errors.- eg.
make -j8 agbcc
. - We may drop support for it in the future, so we recommend updating the code to support the new compilers.
- This will generate
pokeemerald_agbcc.gba
, while modern will generatepokeemerald.gba
by @Bassoonian in #3462
- eg.
🧬 General 🧬
Added
- Incorporated @TheXaman's HGSS Style Pokédex by @AaghatIsLive in #3288
- Includes Dark Mode
- Fix by @AaghatIsLive in #3479
- Updated evolution strings by @Pawkkie in #3375
- Changes to omit adding the code when disabling the feature by @SBird1337 in #3445
- Teachable move list fix by @GraionDilach in #3624
- Includes Dark Mode
- Incorporated @DizzyEggg's nature color branch by @Bassoonian in #3582
- Shows nature stat modifiers in summary screen.
- Added
SUMMARY_SCREEN_NATURE_COLORS
config to disable it. - Updates stat reduction to blue to align with official implementation.
- Added
I_SELL_VALUE_FRACTION
config that changes selling factor of items to 1/4th when set to Gen 9 by @kittenchilly in #3315 - Added
P_FRIENDSHIP_EVO_THRESHOLD
config to update the Friendship evolution threshold to Gen8+'s standard by @kittenchilly in #3376 - Debug Menu
- Added
ROM Space
Utility option to check ROM space by @mrgriffin in #3453 - Added
Toggle Match Call
Flag option to toggle Match Call by @AsparagusEduardo in #3489 - Added
Move Reminder
option by @Bassoonian in #3707 - Moved Party/Boxes related functions to their own menu by @Bassoonian in #3707
- Added
- Added expansion Rom Header by @mrgriffin in #3454
- Added defines for Expansion version number.
- Added option to see the version number in debug menu.
- Added option to restore Japan-only Walda PC backgrounds by @fdeblasio in #3550
- Added
BATTLE_PYRAMID_RANDOM_ENCOUNTERS
config to enable Battle Pyramid Wild Encounter randomization by @ghoulslash in #2581 - Added a
GetSpeciesPreEvolution
function by @LOuroboros in #3696
Changed
- Converted
Get(Box)MonData2
to proper functions by @AsparagusEduardo in #3416 - Added
src/data/map_group_count.h
to.gitignore
by @LOuroboros in #3423 Cheat Start
option now gives all badges and enables all Fly locations.Fly to...
option no longer enables all Fly locations by @AsparagusEduardo in #3489- Better documentation for Type Effectiveness table by @AsparagusEduardo in #3374
- Generational defines now start at
GEN_1
instead ofGEN_3
by @Bassoonian in #3628- Fixes and cleanup
- By @GraionDilach in #3720
- By @AsparagusEduardo in #3723
- Fixes and cleanup
Fixed
- Fixed potential Fly and Badge mismatch when using debug options by @AsparagusEduardo in #3489
- Fixed Pokémon Animation debug menu ignoring animation delay by @AsparagusEduardo in #3562
- Fixed
IS_DITTO
macro by @LOuroboros in #3558 - Added RTC failsafe to Debug menu's
Cheat Start
option by @ravepossum in #3561
🐉 Pokémon 🐉
Added
- Added Generation 9 species up to Teal Mask by @leo60228, @Bassoonian, @AlexOn1ine, @katykat5099, @kittenchilly and @AsparagusEduardo in #3249
- IMPORTANT: Enabling Gen 9 species currently break saves. If you don't want to use them, you can disable
P_GEN_9_POKEMON
ininclude/config/species_enabled.h
.- Reserved Indigo Disk IDs
- By @AsparagusEduardo in #3725
- By @AsparagusEduardo in #3726
- By @Bassoonian in #3727
- Reserved Form IDs that will be supported in future versions by @AsparagusEduardo in #3750
- Shadow Lugia
- Totem Forms
- Partner Pikachu and Eevee
- Reserved Indigo Disk IDs
- Updated UIs to support 4-digit Dex numbers.
- Added Dunsparce and Tandemaus evolution methods by @fdeblasio in #3547
- Tandemaus still does the evolution cutscene for now.
- Ported newer PokéCommunity sprites by @AlexOn1ine in #3643 and #3646
- Fixes and cleanup
- By @fdeblasio in #3539
- By @AsparagusEduardo in #3655 and #3749
- By @katykat5099 in #3751
- IMPORTANT: Enabling Gen 9 species currently break saves. If you don't want to use them, you can disable
- Adjusted Pokemon sprites and palettes - Part 2 by @CyanSMP64 in #3612
- From Magnemite to Tangela + Hitmontop + Nidoking adjustment by MrDollSteak.
- Corrected sprite sizes and elevations
- Further palette adjustments by @CyanSMP64 in #3744
- Pidgeotto, Tentacruel, Feraligatr, Furret, Flaaffy, Marill, Azumarill and Miltank.
- Added missing Alcremie forms by @AsparagusEduardo in #3469
- Previously, only Strawberry Sweet forms were available
- Missing: Icons for non-Ruby Cream forms.
- Cleanup by @Bassoonian in #3488
- Added species define synonyms for base forms with form names by @AsparagusEduardo in #3248
- Eg.
SPECIES_GIRATINA_ALTERED
is equal toSPECIES_GIRATINA
. - The original defines can be used in combination of
GET_BASE_SPECIES_ID(species)
to check for the whole species instead of specific forms.
- Eg.
- Added Gen 7 Pokémon 2nd frames and animations by @katykat5099 in https://github.com/rh...
Version 1.6.2
How to update
- If you haven't set up a remote, run the command
git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion
. - Once you have your remote set up, run the command
git pull RHH expansion/1.6.2
.
🌋 IMPORTANT CHANGES 🌋
Battle changes
- Battler Types are now obtained via
GetBattlerType(battlerId, 0/1/2)
instead ofgBattleMons[battlerId].type1/2/3
to better consider Roost. Be sure to update your custom battle effects to account for this change.
🧬 General 🧬
Fixed
- Fixed Cheat Start not initiating time-based events by @AsparagusEduardo in #3446
🐉 Pokémon 🐉
Changed
- Updated Cresselia's base stats to Gen 9 by @LOuroboros in #3419
- Updated Zacian/Zamazenta base stats to Gen 9 by @AsparagusEduardo in #3421
Fixed
- Fixed Kleavor, Hisuian Sneasel and Sneasler missing their SV abilities by @LOuroboros in #3391
- Fixed Bergmite/Avalugg old and updated egg groups being switched by @AsparagusEduardo in #3380
🤹 Moves 🤹
Changed
- Quick Draw now uses weighted RNG by @Bassoonian in #3399
- Added
IS_BATTLER_TYPELESS
macro that checks if the specified battler has no valid type by @LOuroboros in #3303
Fixed
- Fixed Protect failing if the user flinched on the previous turn by @DizzyEggg in #3345
- Fixed entry hazards not working properly being cleared on switch-in by @DizzyEggg in #3316
- This includes Toxic Spikes not working if Pecha Berry actived on the previous turn.
- Fixed Roost overwriting other type changing at the end of the turn (Soak, Forest's Curse, Color Change, etc.) by @BLourenco in #3258
- Now it suppresses the user's Flying-type rather than remove and re-add it.
- Fixes Salt Cure visual bug if mon fainted by direct attack by @AlexOn1ine in #3388
- Fixed Purifying Salt not preventing the use of Rest by @Bassoonian in #3399
- Fixed Make it Rain lowering Sp. Attack twice if hitting 2 targets in double battles by @AlexOn1ine in #3441
- Fixed Reflect Type not properly handle 3rd types by @LOuroboros in #3303
- Fixed form change triggered by switching not occuring when using moves like U-Turn or Baton Pass by @AlexOn1ine in #3463
- Fixed Last Resort not counting Sleep Talk as used for its effect by @DizzyEggg in #3378
🎭 Abilities 🎭
Changed
- Removed unused
STATUS3_CANT_SCORE_A_CRIT
by @AlexOn1ine in #3377 - Moved Beads of Ruin and Sword of Ruin damage to the appropiate damage modifier functions by @kittenchilly in #3415
Fixed
- Fixed Intimidate increasing the attack of both opponents if one of them has Contrary in double battles by @DizzyEggg in #3365
- Fixed Battle/Shell Armor not preventing critical hits by @AlexOn1ine in #3377
- Fixed Rivalry's effect being reversed by @AsparagusEduardo in #3381
- Fixed Rivalry lowering attack if either attacker or target were genderless by @AsparagusEduardo in #3381
- Fixed missing Poison Heal Ability Popup by @Bassoonian in #3385
- Fixed Parental Bond not working at all by @AsparagusEduardo in #3417
- Fixed Beads of Ruin and Sword of Ruin damage modifiers by @kittenchilly in #3415
- Fixed Sheer Force not negating effects that benefit the user (eg. Flame Charge, Power-Up Punch) by @DizzyEggg in #3378
- Fixed Strength Sap not healing the user when used on a Substitute by @DizzyEggg in #3486
- Fixed Substitute showing the "took damage for" message if Strength Sap was used on it by @DizzyEggg in #3486
- Fixed Weak Armor interrupting Multi Hit moves by @DizzyEggg in #3497
🧶 Items 🧶
Fixed
- Fixed Shiny Charm doing too many rerolls by default by @kittenchilly in #3327
- Fixed Berserk Gene activating for the wrong Pokémon double battles by @DizzyEggg in #3363
- Fixed Red Card not being consumed after opponent Sticky Web activation by @DizzyEggg in #3364
- Fixed implementation of Gen6 that didn't allow for the Exp Share flag to be set via script without setting the item to the Gen 6+ version by @AsparagusEduardo in #3384
- Fixed Kee Berry raising defense by 1 stage instead of 2 by @AlexOn1ine in #3409
- Fixed Kee Berry incorrect stat raise message by @AlexOn1ine in #3409
- Fixed Razor Fang not being able to be used directly even if
I_USE_EVO_HELD_ITEMS_FROM_BAG
was set toTRUE
by @fdeblasio in #3456
🧹 Cleanup 🧹
AbilityBattleEffects
usesB_MSG_TERRAIN
constants for field terrain intro text by @LOuroboros in #3410- Removed all trailing whitespace by @kittenchilly in #3472
🧪 Test Runner 🧪
Added
- Flinch tests by @DizzyEggg in #3345
- Berserk Gene double battle tests by @DizzyEggg in #3363
- More specific Toxic Spikes tests by @DizzyEggg in #3316
- Red Card/Sticky Web test @DizzyEggg in #3364
- Intimidate/Contrary double battle test by @DizzyEggg in #3365
- Critical Hit tests by @AlexOn1ine in #3377
- Roost tests by @BLourenco in #3258
- Rivalry tests by @AsparagusEduardo in #3381
- Various tests by @Bassoonian in #3385
- Defeatist, Dragon's Maw, Earth Eater, Gale Wings, Poison Heal, Rocky Payload, Sap Sipper, Steelworker and Transistor.
- Various tests by @Bassoonian in #3399
- Beast Boost, Ice Scales, Neuroforce, Purifying Salt, Quick Draw and Sharpness.
- Berry tests @AlexOn1ine in #3409
- Full: Apicot, Custap, Ganlon, Jaboca, Kee, Lansat, Liechi, Maranga, Micle, Petaya, Rowap and Salac Berries.
- TODO: Starf Berry.
- Weather and type-specific tests by @kittenchilly in #3260
- Full: Freezing, Hail, Moonlight, Morning Sun, Sandstorm, Snow, Solar Beam/Blade, Steel poisoning, Synthesis, Thunder and Weather Ball.
- Partial: Prankster, Safety Goggles, Aurora Veil, Hurricane, Leech Seed and OHKO moves.
- TODO: Harvest.
- Single Parental Bond test by @AsparagusEduardo in #3417
- Several tests by @DizzyEggg in #3378
- Full: Weak Armor, Last Resort, Stealth Rock.
- Completed Weak Armor tests by @AsparagusEduardo in #3493
- Partial: Defiant, Sheer Force, White Herb, Strength Sap.
- Full: Weak Armor, Last Resort, Stealth Rock.
Changed
- Red Card tests now check if the item was consumed by @DizzyEggg in #3364
- Tests now cannot use
i
in their cycles to avoid messing withPARAMETRIZE
by @mrgriffin in #3408 - Moved battle tests off the heap by @mrgriffin in #3414
- Moved Powder/Grass test to
move_flags
folder by @kittenchilly in #3260 - Continuous
NOT x; NOT y;
are now not allowed in tests due to them not acting as one would expect by @mrgriffin in #3459- Test writers should use
NONE_OF { x; y; }
instead.
- Test writers should use
Fixed
- Fixed CreateNPCTrainerPartyForTrainer test failing on modern by @DizzyEggg in #3367
- Fixed
RNG_CRITICAL_HIT
by @mrgriffin and @AlexOn1ine in https://github.com/rh-hideout/pokeemerald-expansion/p...
pokeemerald-expansion 1.6.1
How to update
- If you haven't set up a remote, run the command
git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion
. - Once you have your remote set up, run the command
git pull RHH expansion/1.6.1
.
CRITICAL FIX, please update to avoid the issues detailed down below:
- Fixed deleting PC mon by placing another one on top with B by @AsparagusEduardo in #3360
Full Changelog: expansion/1.6.0...expansion/1.6.1