fix: stabilize form inputs by avoiding StaleElementExceptions #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll fix up the tests in a day or so, I tried to cherry pick this change but maybe I missed soemthing |
|
Finally got tests passing =) @richardyc These are the cherry picked commits that increased stability on my fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some changes I've made on my end to reduce the amount of StaleElementExceptions as much as possible.
TBH there's a TON of places this can happen due to the nature of the tool. Looping through a crap ton of elements and trying to use them later while the page is loading is kinda asking for it but this is experimental so meh lol.
I hate using Sleeps as much as the next guy but it was my last resort and I wanted to work on other stuff lol