Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update no-style-please.gemspec #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tanvincible
Copy link

PR Description

Summary:

This PR updates the dependency of jekyll-seo-tag in the no-style-please gem to be compatible with GitHub Pages >= 228 and Liquid 4.0.4. The update resolves the version conflict between jekyll-seo-tag 2.7.1 (required by no-style-please) and jekyll-seo-tag 2.8.0 (required by GitHub Pages >= 228).
This change ensures compatibility with Liquid 4.0.4 and fixes a critical bug preventing the site from running correctly when using Liquid 4.0.3.

Changes:

  • Updated the jekyll-seo-tag dependency in the no-style-please gemspec file from ~> 2.7.1 to ~> 2.8.0.
  • This change aligns the no-style-please gem with the newer jekyll-seo-tag version, which is required for compatibility with Liquid 4.0.4 and GitHub Pages >= 228.

Reasoning:

  • The bug in Liquid 4.0.3 is critical and prevents the site from running correctly. This fix updates no-style-please to work with the latest versions of the necessary dependencies.
  • GitHub Pages >= 228 is required for compatibility with Liquid 4.0.4, which is necessary to fix the mentioned bug.
    However, no-style-please depends on an older version of jekyll-seo-tag, which was incompatible with the newer version of GitHub Pages.

Impact:

  • This change ensures that no-style-please works seamlessly with GitHub Pages >= 228 and Liquid 4.0.4.
  • It resolves the version conflict, enabling the website to run without errors related to the Liquid bug.

@tanvincible
Copy link
Author

Is the project still maintained @riggraz?

@riggraz
Copy link
Owner

riggraz commented Dec 15, 2024

No, unfortunately it's not. However I think I can safely merge your PR, it seems you did a very good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility issues with version 0.4.7 and Liquid version 4.0.4
2 participants