Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#436: filter appliance based on value #56

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Conversation

joao-conde
Copy link
Contributor

@joao-conde joao-conde commented Nov 27, 2023

Issue

Decisions

  • sometimes we may not want to apply a filter (e.g. orders:in:VALUE does not make sense to use if the value is not a number) and these conditional functions will add the filter or not based on the returned value
  • specially important for filters that take only certain types of values and may error otherwise

@joao-conde joao-conde added the enhancement New feature or request label Nov 27, 2023
@joao-conde joao-conde self-assigned this Nov 27, 2023
Copy link

Pull Request Test Coverage Report for Build 7008467485

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 89.323%

Totals Coverage Status
Change from base Build 5324368887: -0.1%
Covered Lines: 455
Relevant Lines: 487

💛 - Coveralls

@joao-conde joao-conde requested a review from pmpc94 November 27, 2023 17:38
@joao-conde joao-conde assigned pmpc94 and unassigned joao-conde Nov 27, 2023
Copy link

Pull Request Test Coverage Report for Build 7008811309

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 89.112%

Totals Coverage Status
Change from base Build 5324368887: -0.3%
Covered Lines: 455
Relevant Lines: 487

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7008811309

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 89.323%

Totals Coverage Status
Change from base Build 5324368887: -0.1%
Covered Lines: 455
Relevant Lines: 487

💛 - Coveralls

js/filter.js Show resolved Hide resolved
@pmpc94 pmpc94 assigned joao-conde and unassigned pmpc94 Nov 28, 2023
@joao-conde joao-conde requested a review from pmpc94 November 28, 2023 10:38
@joao-conde joao-conde assigned pmpc94 and unassigned joao-conde Nov 28, 2023
@pmpc94 pmpc94 assigned joao-conde and unassigned pmpc94 Nov 28, 2023
@joao-conde joao-conde merged commit 982377f into master Nov 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants