perf(client): prevent unneeded memory copy in BlobWitnessProvider #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashcashier
reviewed
Dec 21, 2024
| @@ -44,7 +44,7 @@ impl<T: BlobProvider + Send> BlobProvider for BlobWitnessProvider<T> { | |||
| ) -> Result<Vec<Box<Blob>>, Self::Error> { | |||
| let blobs = self.provider.get_blobs(block_ref, blob_hashes).await?; | |||
| for blob in &blobs { | |||
| let c_kzg_blob = c_kzg::Blob::from_bytes(blob.as_slice()).unwrap(); | |||
There was a problem hiding this comment.
This isn't the only host-side occurrence of using from_bytes.
| @@ -44,7 +44,7 @@ impl<T: BlobProvider + Send> BlobProvider for BlobWitnessProvider<T> { | |||
| ) -> Result<Vec<Box<Blob>>, Self::Error> { | |||
| let blobs = self.provider.get_blobs(block_ref, blob_hashes).await?; | |||
| for blob in &blobs { | |||
| let c_kzg_blob = c_kzg::Blob::from_bytes(blob.as_slice()).unwrap(); | |||
| let c_kzg_blob = c_kzg::Blob::new(***blob); | |||
There was a problem hiding this comment.
I believe this change makes the copy implicit (via Copy trait) racer than explicit via from slice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from_bytescreates a copy of the passed slice. We can instead just usenewdirectly which takes ownership of the blob, and prevents the copy, since we don't need it afterwards.