specify a reset for SDICN #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chapter7.adoc
Outdated
Comment on lines
163
to
164
| If `Smsdia` extension is implemented, then `msdcfg.SDICN` is non-zero and holds | ||
| the number of an implemented supervisor domain interrupt controller. |
There was a problem hiding this comment.
Maybe I'm missing something, but I don't see anything to imply this sentence specifies a value at reset. Should there be a heading or something like the following?
Suggested change
| If `Smsdia` extension is implemented, then `msdcfg.SDICN` is non-zero and holds | |
| the number of an implemented supervisor domain interrupt controller. | |
| If `Smsdia` extension is implemented, then at reset `msdcfg.SDICN` is non-zero | |
| and holds the number of an implemented supervisor domain interrupt controller. |
There was a problem hiding this comment.
Yes, its was missing that qualification.
SiFiveHolland
approved these changes
Oct 10, 2024
rsahita
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.