Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sink): support deafult aws credentials for deltalake #19557

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented Nov 25, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#18814
Because delta rs doesn't support sdk config, you need to extract the hashmap

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@hzxa21 hzxa21 changed the title feat(sink): support deafult aws for deltalake feat(sink): support deafult aws credentials for deltalake Nov 27, 2024
@xxhZs xxhZs requested review from yuhao-su, wenym1 and hzxa21 December 18, 2024 03:07
@hzxa21
Copy link
Collaborator

hzxa21 commented Dec 18, 2024

Do we have any CI test or manual test to verify this PR works?

@xxhZs
Copy link
Contributor Author

xxhZs commented Dec 18, 2024

Do we have any CI test or manual test to verify this PR works?

manual test to verify this PR works

@xxhZs xxhZs force-pushed the xxh/support_deltalake_key branch from 02b65de to 6637362 Compare December 18, 2024 11:19
@BugenZhao BugenZhao requested review from xxchan and removed request for BugenZhao December 19, 2024 04:40
@xxhZs xxhZs added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit c022a36 Dec 20, 2024
29 of 30 checks passed
@xxhZs xxhZs deleted the xxh/support_deltalake_key branch December 20, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants