Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sink): support sink rate limit for external sink #19660

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

hzxa21
Copy link
Collaborator

@hzxa21 hzxa21 commented Dec 3, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Closes #16253

Support SET SINK_RATE_LIMIT and ALTER SINK ... SET SINK_RATE_LIMIT for external sink. Sink into table is not supported.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

Support session config SET SINK_RATE_LIMIT to ... and ALTER SINK ... SET SINK_RATE_LIMIT to ... for external sink. Sink into table is not supported. See example in rate_limit.slt

@hzxa21 hzxa21 requested a review from a team as a code owner December 3, 2024 17:29
@hzxa21 hzxa21 requested a review from lmatz December 3, 2024 17:29
@graphite-app graphite-app bot requested a review from a team December 4, 2024 14:11
@lmatz lmatz added the user-facing-changes Contains changes that are visible to users label Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Hi, there.

📝 Telemetry Reminder:
If you're implementing this feature, please consider adding telemetry metrics to track its usage. This helps us understand how the feature is being used and improve it further.
You can find the function report_event of telemetry reporting in the following files. Feel free to ask questions if you need any guidance!

  • src/frontend/src/telemetry.rs
  • src/meta/src/telemetry.rs
  • src/stream/src/telemetry.rs
  • src/storage/compactor/src/telemetry.rs
    Or calling report_event_common (src/common/telemetry_event/src/lib.rs) as if finding it hard to implement.
    ✨ Thank you for your contribution to RisingWave! ✨

This is an automated comment created by the peaceiris/actions-label-commenter. Responding to the bot or mentioning it won't have any effect.

@tabVersion
Copy link
Contributor

quick question: if the sink rate limit makes more data buffered in LogStore?

@hzxa21
Copy link
Collaborator Author

hzxa21 commented Dec 6, 2024

quick question: if the sink rate limit makes more data buffered in LogStore?

If sink decoupled is on, yes. If sink decoupled is off, it will cause backpressure.

@hzxa21 hzxa21 force-pushed the patrick/sink-rate-limit.pr branch 2 times, most recently from 66b212a to 908c638 Compare December 16, 2024 06:06
@hzxa21 hzxa21 force-pushed the patrick/sink-rate-limit.pr branch from 11e522e to e656194 Compare December 19, 2024 02:07
@hzxa21 hzxa21 force-pushed the patrick/sink-rate-limit.pr branch from e656194 to e7217ba Compare December 19, 2024 08:44
Copy link
Contributor

@MrCroxx MrCroxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support rate limit of sink
4 participants