-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sink): support sink rate limit for external sink #19660
base: main
Are you sure you want to change the base?
Conversation
Hi, there. 📝 Telemetry Reminder:
|
quick question: if the sink rate limit makes more data buffered in LogStore? |
If sink decoupled is on, yes. If sink decoupled is off, it will cause backpressure. |
66b212a
to
908c638
Compare
11e522e
to
e656194
Compare
e656194
to
e7217ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Closes #16253
Support
SET SINK_RATE_LIMIT
andALTER SINK ... SET SINK_RATE_LIMIT
for external sink. Sink into table is not supported.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
Support session config
SET SINK_RATE_LIMIT to ...
andALTER SINK ... SET SINK_RATE_LIMIT to ...
for external sink. Sink into table is not supported. See example in rate_limit.slt