feat: support pg_stat_user_tables and key_column_usage #19739
+227
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yezizp2012
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
LGTM, can we add some reliable e2e for them like https://github.com/risingwavelabs/risingwave/blob/main/e2e_test/batch/catalog/issue_8791.slt.part, for example:
select * from information_schema.key_column_usage where 1 != 1;
|
Sure. Will do |
hzxa21
force-pushed
the
patrick/metabase-catalog-fix
branch
from
e330eb2 to
452d006
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| /// The view `key_column_usage` contains all constraints belonging to tables that the current user owns or has some privilege other than SELECT on. | ||
| /// Ref: [`https://www.postgresql.org/docs/current/infoschema-key-column-usage.html`] | ||
| /// Limitation: | ||
| /// This view assume the constraint schema is the same as the table schema, since `pg_clatalog`.`pg_constraint` only support primrary key. |
There was a problem hiding this comment.
There's a typo in the comment: primrary should be primary in the limitation note. Also, there's a typo in pg_clatalog which should be pg_catalog.
The corrected comment should read: "...since pg_catalog.pg_constraint only supports primary key."
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Resolves #17753
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.