Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): skip unnecessary delta persistence #19878

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Dec 20, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

During commit_epoch for newly created table, a GroupConstruct delta is expected, which triggers a false alarm. The alarm was added to assert only NewL0SubLevel delta was kept for time travel.

This PR resolves this issue by skipping delta contaning GroupConstruct for time travel, because for that delta a complete version snapshot is ensured to be created for time travel, based on should_mark_next_time_travel_version_snapshot. This redundant delta has never been used.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zwang28 zwang28 added this pull request to the merge queue Dec 24, 2024
Merged via the queue into main with commit 16c7fcd Dec 24, 2024
54 of 55 checks passed
@zwang28 zwang28 deleted the wangzheng/fix_false_alarm branch December 24, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants