-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown in descriptions #4405
Open
dejanbelusic
wants to merge
7
commits into
rjsf-team:main
Choose a base branch
from
dejanbelusic:markdown-in-object-and-checkbox-descriptions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Markdown in descriptions #4405
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e195be6
Fix typo
dejanbelusic bc3acf3
Render markdown in 'CheckboxWidget' component
dejanbelusic 234a0f0
Render markdown in 'ObjectField'
dejanbelusic a7529dc
Update CHANGELOG.md
dejanbelusic de02a01
Merge branch 'main' into markdown-in-object-and-checkbox-descriptions
heath-freenome f2f0616
Update CHANGELOG.md
heath-freenome b9bddd8
Update packages/utils/src/types.ts
heath-freenome File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dejanbelusic after looking around it turns out that every theme's
CheckboxWidget
has a similar description rendering logic in it. We suggest creating a new component in the@rjsf/utils
package that wraps this logic as follows and then updating everyFieldDescriptionTemplate
to use it:With all the
FieldDescriptionTemplates
calling it similarly to the change that would be made in@rjsf/core
's implementation:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @heath-freenome, I see your point and I agree. I can create a new component
RichDescription
as suggested, place it in the@rjsf/utils
, and then use it in everyDescriptionField
component.When looking into
DescriptionField
components, I can see that one in@rjsf/antd
packages is wrapped in aspan
, the one in@rjsf/bootstrap-4
is wrapped in twodiv
s, the one in@rjsf/chakra-ui
package is wrapped inText
component... What I'm saying is every theme has similar, but different implementation. Do I leave them as is?