Remove use of sqlite db, server service, and ansible dependency #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sqlite DB and server service are not necessary. There's no need to store servers in a database as we are actively scanning the network periodically and providing updates via events. Configs are now stored in a json file. Similarly, having a dependency on ansible just to get hostname and os info seems silly. The same is now achieved just using plain 'ol ssh and "uname -a" command.
robgonnella
force-pushed
the
remove-sqldb-and-server-service
branch
from
bfd599a
to
0068db0
Compare
robgonnella
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not necessary. There's no need to store servers in a database as we are actively scanning the network periodically and providing updates via events. Configs are now stored in a json file.