Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address 0.25.0 release PR comments #1660

Merged
merged 12 commits into from
Nov 12, 2024
Merged

Conversation

LinasKo
Copy link
Collaborator

@LinasKo LinasKo commented Nov 7, 2024

Description

This PR addresses comments on the release PR.

  1. Improve Discord Icon in README
  2. Using KeyPoints.as_detections() for conversion before keypoint tracking
  3. Removed LineZone property dosctrings, added to 'Attribute' section in class LineZone docstring. This is consistent with PolygonZone.
  4. Split How To guide for KeyPoints into multiple sections
  5. Added metrics plots
  6. Added metrics print results

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

  1. Looked at + clicked discord icon in the README: https://github.com/roboflow/supervision/tree/fix/address-release-pr-comments
  • The change includes whitespace changes to the README, but I cannot spot any regressions.
  1. Built docs, checked utils, keypoints, How-To-Track sections. Colab: https://colab.research.google.com/drive/10PMuW0IyaksofqI70NLnB_-Fnr4oKVmk?usp=sharing
  2. Checked docs for LineZone attributes.
  3. See http://127.0.0.1:8000/how_to/track_objects/#keypoints
  4. see metrics docs, check for charts
  5. see metrics docs, check for print results

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc.

Docs

  • Docs updated? What were the changes:

@LinasKo LinasKo marked this pull request as ready for review November 12, 2024 09:55
@LinasKo LinasKo merged commit aae3c69 into develop Nov 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants