Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions versions to Node 20 #94

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

sciencewhiz
Copy link
Contributor

No description provided.

@@ -123,7 +123,7 @@ jobs:
RPYBUILD_STRIP_LIBPYTHON: "1"
RPYBUILD_CC_LAUNCHER: ccache

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: "dist-${{ runner.os }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work. This workflow is currently relying on the merging behaviour in artifacts v3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, I saw there was names for each but didn't realize they weren't unique.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching the workflow will also require changing the way docs are built, currently RTD downloads the docs from github actions via https://github.com/robotpy/robotpy-sphinx-plugin/blob/main/robotpy_sphinx/download_and_install.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming I did the merging correctly, the artifacts should have the same name and contents, so it looks like that should still work, unless I'm missing something. There are temporary artifacts created, but they are deleted after merging.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me like the artifacts are the same as before.

@sciencewhiz sciencewhiz marked this pull request as draft June 11, 2024 01:16
@sciencewhiz sciencewhiz marked this pull request as ready for review June 11, 2024 04:58
@PeterJohnson PeterJohnson merged commit 868f50a into robotpy:main Jun 11, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants