Updated robotcontainer.py and constants.py for the maxswerve example … #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to match updates to the commands2 class.
Added the line to enable continuous inputs on the ProfiledPIDController.
Oops, changed the wrong PID controller.
|
We can ignore the build failures because CI doesn't actually run the examples. Just make sure the check task succeeds and we're good to go here. |
|
I'll check them on real hardware later today, and I'll let you know if all the tests pass. |
|
Looks like the check task succeeded. Sorry it took so long, I've been balancing homework with programming recently, and CI is very particular. |
It's not too particular, we just run black to format the code. |
|
Thanks! I didn't realize that that was an option. I'll definitely use that in the future. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to match updates to the commands2 class.
Hi, I'm Henry from team 9068, The Chargers. I realize that our previous fork was incorrect, so I updated our fork to be a direct fork of the repository rather than the singular example. Sorry for the confusion, let me know if you need to change anything.