Updated supported and tested frameworks and modernized tests and packaging. #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmorell
changed the title
alif
reviewed
Sep 13, 2024
| @@ -523,7 +525,7 @@ def test_get_request_fastapi_router(self): | |||
| def root(fastapi_request: Request): | |||
| current_request = rollbar.get_request() | |||
|
|
|||
| self.assertEqual(current_request, fastapi_request) | |||
| self.assertEqual(get_public_attrs(current_request), get_public_attrs(fastapi_request)) | |||
There was a problem hiding this comment.
Are the failsafe comments on this file below from GH Actions a concern?
There was a problem hiding this comment.
They come from the testsuite raising errors to ensure the library catches and reports errors correctly. One of these days I will make them go away, so our reports are cleaner. So, not a concern just an annoyance.
alif
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR updates and provides better documentation about the framework versions we support and test against.
The other change in this PR is to modernize our packaging and testing. I have replaced the
setup.pyfile with apyproject.tomlfile and added a minimal tox setup for running tests.Type of change
Related issues
To get the tests to pass on all version of Python, I also had to resolve this issue.
Checklists
Development
Code review