[POC/WIP] Add optional Bip352 silentpayments index #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlest01
force-pushed
the
bip352-silentpayments-module
branch
from
6df1529 to
c1e110c
Compare
but I can make silent payments to the node, from a client? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a new
--silent-payments-indexoption that creates an index of Bip352 silent payments.Most of the code is based on @Sosthene00's fork, but I made the following changes:
. It uses bitcoin-core/secp256k1#1519 and rust-bitcoin/rust-secp256k1#721 instead of the
rust-silentpaymentscrate.. It adds a new
--silent-payments-indexconfiguration option. Without this option, the server does not index silent payments and works the same as it does today.. The code does not use
Box[u8]indb.rs.To run this, something like the following command can be used:
cargo run -- --log-filters=INFO --db-dir <db_dir> --daemon-dir ~/.bitcoin/ --network signet --electrum-rpc-addr="127.0.0.1:60001" --silent-payments-index