Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customizable color scale for visualization #18

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

SammyRamone
Copy link
Contributor

@SammyRamone SammyRamone commented Jul 25, 2023

See ros-industrial/reach#58

edit: building of CI fails as the mentioned PR is required as a basis

@acbuynak
Copy link

Is red to green a good choice? These colors are commonly difficult to distinguish for color blind people.

@SammyRamone
Copy link
Contributor Author

You are right, but I don't want to change the default, just give another option.
In my cultural setting (Germany) people typically just expect a range from bad->good being represented by red->green.

Anyway, this PR will be changed based on the discussion here ros-industrial/reach#58

@gavanderhoorn
Copy link
Member

Is red to green a good choice? These colors are commonly difficult to distinguish for color blind people.

I was going to post something similar.

Most flexible option would be to allow configuring colour scales. But that might require more work.

@marip8
Copy link
Member

marip8 commented Aug 16, 2023

/usr/bin/ld: /opt/ros/rolling/lib/libinteractive_markers.so: undefined reference to `rclcpp::TimerBase::TimerBase(std::shared_ptrrclcpp::Clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> >, std::shared_ptrrclcpp::Context, bool)'

Any ideas why this is happening on the rolling build? It seems to happen when we link the reach study node to the library being built by this repo. I'm not sure why some distributed library that is not being built in this repo is complaining about an undefined reference

@marip8
Copy link
Member

marip8 commented Aug 16, 2023

/usr/bin/ld: /opt/ros/rolling/lib/libinteractive_markers.so: undefined reference to `rclcpp::TimerBase::TimerBase(std::shared_ptrrclcpp::Clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> >, std::shared_ptrrclcpp::Context, bool)'

Any ideas why this is happening on the rolling build? It seems to happen when we link the reach study node to the library being built by this repo. I'm not sure why some distributed library that is not being built in this repo is complaining about an undefined reference

Turns out the rolling docker image is not up to date. Running apt upgrade in the container before building solves this issue. Rather than running apt upgrade on the image in CI, I think we should wait for the image to be updated so we continue to build on a nominal image

@marip8 marip8 changed the title Add red to green color scale Add customizable color scale for visualization Aug 16, 2023
@marip8 marip8 merged commit 4e792dc into ros-industrial:master Aug 16, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants