Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set -mno-avx512f flag for all binary deb jobs #1012

Closed
wants to merge 1 commit into from

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Oct 10, 2023

This was discussed during the ROS 2 weekly meeting today, and is necessary to avoid the automatic addition of avx512 opcodes when we happen to build packages on a supported Xeon processor.

@cottsay
Copy link
Member Author

cottsay commented Oct 10, 2023

Now that I think about it, we may be able to do this with build_environment_variables in the config. Since the type of machine is more so an artifact of our buildfarm configuration, that would be a more appropriate place to place this constraint.

@cottsay
Copy link
Member Author

cottsay commented Oct 10, 2023

Ooh, also, I'm not sure how this flag will behave if presented to an ARM build.

@cottsay cottsay changed the title Set -no-avx512f flag for all binary deb jobs Set -mno-avx512f flag for all binary deb jobs Oct 10, 2023
@cottsay
Copy link
Member Author

cottsay commented Oct 10, 2023

Closing in favor of ros2/ros_buildfarm_config#288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant