Skip to content

Commit

Permalink
Allow vcs-repo-file-url to be empty (#225)
Browse files Browse the repository at this point in the history
* allow vcs-repo-file-url to be empty

Signed-off-by: Miaofei <miaofei@amazon.com>

* address pr comments and add test

Signed-off-by: Miaofei <miaofei@amazon.com>

* attempt to fix new tests

Signed-off-by: Miaofei <miaofei@amazon.com>

* remove new tests, which don't work

Signed-off-by: Miaofei <miaofei@amazon.com>
  • Loading branch information
mm318 authored Jun 9, 2020
1 parent 242ffcc commit 0723c72
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4902,9 +4902,7 @@ function run() {
const sourceRosBinaryInstallationList = sourceRosBinaryInstallation
? sourceRosBinaryInstallation.split(RegExp("\\s"))
: [];
const vcsRepoFileUrlListAsString = core.getInput("vcs-repo-file-url", {
required: true
});
const vcsRepoFileUrlListAsString = core.getInput("vcs-repo-file-url") || "";
const vcsRepoFileUrlList = vcsRepoFileUrlListAsString.split(RegExp("\\s"));
const vcsRepoFileUrlListNonEmpty = vcsRepoFileUrlList.filter(x => x != "");
const vcsRepoFileUrlListResolved = vcsRepoFileUrlListNonEmpty.map(x => resolveVcsRepoFileUrl(x));
Expand Down
4 changes: 1 addition & 3 deletions src/action-ros-ci.ts
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,7 @@ async function run() {
? sourceRosBinaryInstallation.split(RegExp("\\s"))
: [];

const vcsRepoFileUrlListAsString = core.getInput("vcs-repo-file-url", {
required: true
});
const vcsRepoFileUrlListAsString = core.getInput("vcs-repo-file-url") || "";
const vcsRepoFileUrlList = vcsRepoFileUrlListAsString.split(RegExp("\\s"));
const vcsRepoFileUrlListNonEmpty = vcsRepoFileUrlList.filter(x => x != "");
const vcsRepoFileUrlListResolved = vcsRepoFileUrlListNonEmpty.map(x =>
Expand Down

0 comments on commit 0723c72

Please sign in to comment.